Implement demo project transfer (#524)

This will allow users to reparent their demo project under their own gcp organization to keep it running

Author: michaeljguarino

Makefile

@@ -73,3 +73,10 @@ migration:
 
 yarn-add: ## adds a yarn dep to the react interface
 	cd www && yarn add $(dep)
+
+release-vsn: # tags and pushes a new release
+	@read -p "Version: " tag; \
+	git checkout master; \
+	git pull --rebase; \
+	git tag -a $$tag -m "new release"; \
+	git push origin $$tag

apps/core/lib/core/services/shell/demo.ex

@@ -3,7 +3,7 @@ defmodule Core.Services.Shell.Demo do
   alias Core.Schema.{User, DemoProject}
   alias Core.Services.{Locks, Users, Upgrades, Repositories}
   alias GoogleApi.CloudResourceManager.V3.Api.{Projects, Operations}
-  alias GoogleApi.CloudResourceManager.V3.Model.{Project, Operation, SetIamPolicyRequest}
+  alias GoogleApi.CloudResourceManager.V3.Model.{Project, Operation, SetIamPolicyRequest, MoveProjectRequest}
   alias GoogleApi.CloudResourceManager.V3.Connection, as: ProjectsConnection
   alias GoogleApi.IAM.V1.Connection, as: IAMConnection
   alias GoogleApi.IAM.V1.Api.Projects, as: IAMProjects
@@ -18,13 +18,17 @@ defmodule Core.Services.Shell.Demo do
 
 
   @type error :: {:error, term}
+  @type demo_resp :: {:ok, DemoProject.t} | error
 
   @lock "demo-projects"
   @max_count 3
 
   @spec get_demo_project(binary) :: DemoProject.t | nil
   def get_demo_project(id), do: Core.Repo.get(DemoProject, id)
 
+  @spec get_by_user_id(binary) :: DemoProject.t | nil
+  def get_by_user_id(id), do: Core.Repo.get_by(DemoProject, user_id: id)
+
   @doc """
   Returns at most `limit` demo projects for deletion.  This operation should be atomic, and will mark each project with
   a heartbeat ts to track status in the deletion pipeline.
@@ -93,6 +97,33 @@ defmodule Core.Services.Shell.Demo do
     |> execute(extract: :final)
   end
 
+  @doc """
+  Transfers a demo project to another organization
+  """
+  @spec transfer_demo_project(binary, User.t) :: demo_resp
+  def transfer_demo_project(org_id, %User{id: user_id}) do
+    demo = get_by_user_id(user_id)
+    projs = projects_conn()
+
+    start_transaction()
+    |> add_operation(:move, fn _ ->
+      Projects.cloudresourcemanager_projects_move(projs, demo.project_id, body: %MoveProjectRequest{
+        destinationParent: "organizations/#{org_id}"
+      })
+      |> IO.inspect() # useful for testing
+    end)
+    |> add_operation(:shell, fn _ ->
+      with %{} = shell <- Core.Services.Shell.get_shell(user_id) do
+        Ecto.Changeset.change(shell, %{demo_id: nil})
+        |> Core.Repo.update()
+      else
+        _ -> {:ok, nil}
+      end
+    end)
+    |> add_operation(:delete, fn _ -> Core.Repo.delete(demo) end)
+    |> execute(extract: :delete)
+  end
+
   @doc """
   Deletes the demo project and its associated gcp project
   """

apps/core/test/services/shell/demo_test.exs

@@ -151,6 +151,26 @@ defmodule Core.Services.Shell.DemoTest do
     end
   end
 
+  describe "#transfer_demo_project/2" do
+    test "it will transfer a users demo project" do
+      demo = insert(:demo_project)
+      shell = insert(:cloud_shell, demo: demo, user: demo.user)
+
+      proj_id = demo.project_id
+      expect(Goth.Token, :for_scope, fn _ -> {:ok, %{token: "token"}} end)
+      expect(Projects, :cloudresourcemanager_projects_move, fn _, ^proj_id, [body: %{destinationParent: "organizations/org-id"}] ->
+        {:ok, %{}}
+      end)
+
+      {:ok, res} = Demo.transfer_demo_project("org-id", demo.user)
+
+      assert res.id == demo.id
+
+      refute refetch(demo)
+      refute refetch(shell).demo_id
+    end
+  end
+
   describe "#poll/1" do
     test "it will fetch a list of projects to delete" do
       expired = Timex.now() |> Timex.shift(hours: -10)

apps/graphql/lib/graphql/resolvers/shell.ex

@@ -17,6 +17,9 @@ defmodule GraphQl.Resolvers.Shell do
   def create_demo_project(_, %{context: %{current_user: user}}),
     do: Shell.Demo.create_demo_project(user)
 
+  def transfer_demo_project(%{organization_id: org}, %{context: %{current_user: user}}),
+    do: Shell.Demo.transfer_demo_project(org, user)
+
   def reboot(_, %{context: %{current_user: user}}), do: Shell.reboot(user.id)
 
   def stop(_, %{context: %{current_user: user}}), do: Shell.stop(user)

apps/graphql/lib/graphql/schema/shell.ex

@@ -144,6 +144,13 @@ defmodule GraphQl.Schema.Shell do
       safe_resolve &Shell.create_demo_project/2
     end
 
+    field :transfer_demo_project, :demo_project do
+      middleware Authenticated
+      arg :organization_id, non_null(:string)
+
+      safe_resolve &Shell.transfer_demo_project/2
+    end
+
     field :stop_shell, :boolean do
       middleware Authenticated
       safe_resolve &Shell.stop/2

apps/graphql/test/mutations/shell_mutations_test.exs

@@ -3,6 +3,7 @@ defmodule GraphQl.ShellMutationsTest do
   use Mimic
   import GraphQl.TestHelpers
   alias Core.Services.Shell.Pods
+  alias GoogleApi.CloudResourceManager.V3.Api.Projects
 
   describe "createShell" do
     test "it will create a new shell instance" do
@@ -89,7 +90,7 @@ defmodule GraphQl.ShellMutationsTest do
     test "it will create a new demo project" do
       user = insert(:user)
       expect(Goth.Token, :for_scope, fn _ -> {:ok, %{token: "token"}} end)
-      expect(GoogleApi.CloudResourceManager.V3.Api.Projects, :cloudresourcemanager_projects_create, fn _, [body: _] ->
+      expect(Projects, :cloudresourcemanager_projects_create, fn _, [body: _] ->
         {:ok, %{name: "operations/123"}}
       end)
 
@@ -144,4 +145,25 @@ defmodule GraphQl.ShellMutationsTest do
       assert refetch(shell)
     end
   end
+
+  describe "transferDemoProject" do
+    test "it will send out a tranfer request" do
+      demo = insert(:demo_project)
+
+      proj_id = demo.project_id
+      expect(Goth.Token, :for_scope, fn _ -> {:ok, %{token: "token"}} end)
+      expect(Projects, :cloudresourcemanager_projects_move, fn _, ^proj_id, [body: %{destinationParent: "organizations/org-id"}] ->
+        {:ok, %{}}
+      end)
+
+      {:ok, %{data: %{"transferDemoProject" => %{"id" => id}}}} = run_query("""
+        mutation {
+          transferDemoProject(organizationId: "org-id") { id }
+        }
+      """, %{}, %{current_user: demo.user})
+
+      assert id == demo.id
+      refute refetch(demo)
+    end
+  end
 end

apps/worker/mix.exs

@@ -56,7 +56,8 @@ defmodule Worker.MixProject do
   defp deps do
     [
       {:k8s_traffic_plug, github: "Financial-Times/k8s_traffic_plug"},
-      {:core, in_umbrella: true}
+      {:core, in_umbrella: true},
+      {:email, in_umbrella: true}
     ]
   end
 end