Add additional promote tags to test objects (#778)

Author: michaeljguarino

apps/core/lib/core/schema/test.ex

@@ -10,6 +10,7 @@ defmodule Core.Schema.Test do
     field :name,        :string
     field :source_tag,  :string
     field :promote_tag, :string
+    field :tags,        {:array, :string}
     field :status,      Status
 
     belongs_to :repository, Repository
@@ -41,7 +42,7 @@ defmodule Core.Schema.Test do
     from(t in query, order_by: ^order)
   end
 
-  @valid ~w(name source_tag promote_tag status repository_id creator_id)a
+  @valid ~w(name source_tag promote_tag status repository_id creator_id tags)a
 
   def changeset(model, attrs \\ %{}) do
     model

apps/core/lib/core/services/tests.ex

@@ -6,7 +6,8 @@ defmodule Core.Services.Tests do
     User,
     Test,
     TestStep,
-    Version
+    Version,
+    VersionTag
   }
   alias Core.Services.{Versions, Repositories}
 
@@ -80,11 +81,13 @@ defmodule Core.Services.Tests do
 
     bindings
     |> Enum.reduce(start_transaction(), fn %{version: version}, tx ->
-      add_operation(tx, version.id, fn _ ->
-        case compare_vsn(version, tag) do
-          :gt -> Versions.create_tag(version, tag)
-          _ -> {:ok, :ignore}
-        end
+      Enum.reduce([tag | (test.tags || [])], tx, fn tag, tx ->
+        add_operation(tx, {tag, version.id}, fn _ ->
+          case compare_vsn(version, tag) do
+            :gt -> Versions.create_tag(version, tag)
+            _ -> {:ok, :ignore}
+          end
+        end)
       end)
     end)
     |> execute()
@@ -144,12 +147,12 @@ defmodule Core.Services.Tests do
   end
 
   defp send_notifs(results, user) do
-    Enum.map(results, fn
-      {k, :ignore} -> {k, :ignore}
-      {k, vt} ->
-        %{version: vsn} = Core.Repo.preload(vt, [:version])
-        {:ok, _} = Versions.notify({:ok, vsn}, :update, user)
-        {k, vsn}
+    Enum.filter(results, fn {_, v} -> v != :ignore end)
+    |> Enum.uniq_by(fn {_, %VersionTag{version_id: v}} -> v end)
+    |> Enum.map(fn {{_, k}, vt} ->
+      %{version: vsn} = Core.Repo.preload(vt, [:version])
+      {:ok, _} = Versions.notify({:ok, vsn}, :update, user)
+      {k, vsn}
     end)
     |> Enum.into(%{})
     |> ok()

apps/core/priv/repo/migrations/20221118204819_add_test_promote_tags.exs

@@ -0,0 +1,9 @@
+defmodule Core.Repo.Migrations.AddTestPromoteTags do
+  use Ecto.Migration
+
+  def change do
+    alter table(:tests) do
+      add :tags, {:array, :string}
+    end
+  end
+end

apps/core/test/services/tests_test.exs

@@ -105,6 +105,19 @@ defmodule Core.Services.TestsTest do
         assert_receive {:event, %PubSub.VersionUpdated{item: %{id: ^id}}}
       end
     end
+
+    test "it can also promote associated tags" do
+      test = insert(:test, status: :succeeded, promote_tag: "stable", tags: ["0.3.0"])
+      bindings = insert_list(3, :test_binding, test: test)
+
+      {:ok, _} = Tests.promote(test)
+
+      for %{version: %{id: id} = version} <- bindings do
+        assert Versions.get_tag(:helm, version.chart_id, "stable").version_id == id
+        assert Versions.get_tag(:helm, version.chart_id, "0.3.0").version_id == id
+        assert_receive {:event, %PubSub.VersionUpdated{item: %{id: ^id}}}
+      end
+    end
   end
 
   describe "#expire/1" do

apps/graphql/lib/graphql/schema/test.ex

@@ -12,6 +12,7 @@ defmodule GraphQl.Schema.Test do
     field :name,        :string
     field :status,      :test_status
     field :promote_tag, :string
+    field :tags,        list_of(:string)
     field :steps,       list_of(:test_step_attributes)
   end
 
@@ -29,6 +30,7 @@ defmodule GraphQl.Schema.Test do
     field :status,      non_null(:test_status)
     field :source_tag,  non_null(:string)
     field :promote_tag, non_null(:string)
+    field :tags,        list_of(non_null(:string))
     field :steps,       list_of(:test_step), resolve: dataloader(Test)
     field :creator,     :user, resolve: dataloader(User)
     field :repository,  :repository, resolve: dataloader(Repository)

mix.lock

@@ -137,7 +137,7 @@
   "stripity_stripe": {:hex, :stripity_stripe, "2.17.2", "6e4c5f0b2deb3d3411f91e23fedbe9db4c031a52dfeb7074b4df4fdd22ad32cd", [:mix], [{:hackney, "~> 1.15", [hex: :hackney, repo: "hexpm", optional: false]}, {:jason, "~> 1.1", [hex: :jason, repo: "hexpm", optional: false]}, {:plug, "~> 1.0", [hex: :plug, repo: "hexpm", optional: true]}, {:uri_query, "~> 0.1.2", [hex: :uri_query, repo: "hexpm", optional: false]}], "hexpm", "42bffb591d34f3cfa95cb37e862140e44a61ca4c64578bf7bb591ba60c6a66bc"},
   "swarm": {:hex, :swarm, "3.4.0", "64f8b30055d74640d2186c66354b33b999438692a91be275bb89cdc7e401f448", [:mix], [{:gen_state_machine, "~> 2.0", [hex: :gen_state_machine, repo: "hexpm", optional: false]}, {:libring, "~> 1.0", [hex: :libring, repo: "hexpm", optional: false]}], "hexpm", "94884f84783fc1ba027aba8fe8a7dae4aad78c98e9f9c76667ec3471585c08c6"},
   "sweet_xml": {:hex, :sweet_xml, "0.7.3", "debb256781c75ff6a8c5cbf7981146312b66f044a2898f453709a53e5031b45b", [:mix], [], "hexpm", "e110c867a1b3fe74bfc7dd9893aa851f0eed5518d0d7cad76d7baafd30e4f5ba"},
-  "telemetry": {:hex, :telemetry, "1.1.0", "a589817034a27eab11144ad24d5c0f9fab1f58173274b1e9bae7074af9cbee51", [], [], "hexpm", "b727b2a1f75614774cff2d7565b64d0dfa5bd52ba517f16543e6fc7efcc0df48"},
+  "telemetry": {:hex, :telemetry, "1.1.0", "a589817034a27eab11144ad24d5c0f9fab1f58173274b1e9bae7074af9cbee51", [:rebar3], [], "hexpm", "b727b2a1f75614774cff2d7565b64d0dfa5bd52ba517f16543e6fc7efcc0df48"},
   "telemetry_metrics": {:hex, :telemetry_metrics, "0.6.1", "315d9163a1d4660aedc3fee73f33f1d355dcc76c5c3ab3d59e76e3edf80eef1f", [:mix], [{:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "7be9e0871c41732c233be71e4be11b96e56177bf15dde64a8ac9ce72ac9834c6"},
   "telemetry_poller": {:hex, :telemetry_poller, "1.0.0", "db91bb424e07f2bb6e73926fcafbfcbcb295f0193e0a00e825e589a0a47e8453", [:rebar3], [{:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "b3a24eafd66c3f42da30fc3ca7dda1e9d546c12250a2d60d7b81d264fbec4f6e"},
   "tesla": {:hex, :tesla, "1.4.3", "f5a494e08fb1abe4fd9c28abb17f3d9b62b8f6fc492860baa91efb1aab61c8a0", [:mix], [{:castore, "~> 0.1", [hex: :castore, repo: "hexpm", optional: true]}, {:exjsx, ">= 3.0.0", [hex: :exjsx, repo: "hexpm", optional: true]}, {:finch, "~> 0.3", [hex: :finch, repo: "hexpm", optional: true]}, {:fuse, "~> 2.4", [hex: :fuse, repo: "hexpm", optional: true]}, {:gun, "~> 1.3", [hex: :gun, repo: "hexpm", optional: true]}, {:hackney, "~> 1.6", [hex: :hackney, repo: "hexpm", optional: true]}, {:ibrowse, "4.4.0", [hex: :ibrowse, repo: "hexpm", optional: true]}, {:jason, ">= 1.0.0", [hex: :jason, repo: "hexpm", optional: true]}, {:mime, "~> 1.0", [hex: :mime, repo: "hexpm", optional: false]}, {:mint, "~> 1.0", [hex: :mint, repo: "hexpm", optional: true]}, {:poison, ">= 1.0.0", [hex: :poison, repo: "hexpm", optional: true]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: true]}], "hexpm", "e0755bb664bf4d664af72931f320c97adbf89da4586670f4864bf259b5750386"},