Merge pull request #45 from pluralsh/fix-nil-pointer-deref

michaeljguarino · web-flow · commit 96d9c18a1217 · 2024-07-05T20:29:00.000-04:00
Fix nil pointer dereference in tf provider
diff --git a/internal/resource/cluster.go b/internal/resource/cluster.go
@@ -153,7 +153,7 @@ func (r *clusterResource) Delete(ctx context.Context, req resource.DeleteRequest
 
 		if err = wait.PollWithContext(ctx, 10*time.Second, 10*time.Minute, func(ctx context.Context) (bool, error) {
 			response, err := r.client.GetCluster(ctx, data.Id.ValueStringPointer())
-			if client.IsNotFound(err) || response.Cluster == nil {
+			if client.IsNotFound(err) || response == nil || response.Cluster == nil {
 				return true, nil
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func (r *clusterResource) Delete(ctx context.Context, req resource.DeleteRequest`
`153`	`153`
`154`	`154`	`if err = wait.PollWithContext(ctx, 10time.Second, 10time.Minute, func(ctx context.Context) (bool, error) {`
`155`	`155`	`response, err := r.client.GetCluster(ctx, data.Id.ValueStringPointer())`
`156`		`- if client.IsNotFound(err) \|\| response.Cluster == nil {`
	`156`	`+ if client.IsNotFound(err) \|\| response == nil \|\| response.Cluster == nil {`
`157`	`157`	`return true, nil`
`158`	`158`	`}`
`159`	`159`