Fix FromReadBindings (#96)

Author: JohnBlackwell

example/cloudconnection/main.tf

@@ -43,9 +43,9 @@ data "plural_user" "john_doe" {
 ###############################################################################
 
 # Group that will get read access to the cloud connection
-resource "plural_group" "cloud_admins" {
-  name        = "cloud-admins"
-  description = "Group with access to cloud connections"
+
+data "plural_group" "existing-cloud_admins" {
+  name        = "existing-cloud-admins"
 }
 
 # Cloud-connection resource (AWS example)
@@ -63,16 +63,10 @@ resource "plural_cloud_connection" "aws" {
 
   read_bindings = [
     {
-      id      = "1122"
-      user_id = data.plural_user.john.id
-    },
-    {
-      id      = "2233"
-      group_id = plural_group.cloud_admins.id
+      user_id = data.plural_user.john_doe.id
     },
     {
-      id      = "4444"
-      group_id = plural_group.cloud_admins.id
+      group_id = data.plural_group.existing-cloud_admins.id
     }
   ]
 }
@@ -93,6 +87,6 @@ output "cloud_connection_details" {
 }
 
 output "group_id" {
-  value       = plural_group.cloud_admins.id
+  value       = data.plural_group.existing-cloud_admins.id
   description = "ID of the created group"
 }

internal/common/bindings.go

@@ -90,9 +90,11 @@ func bindingsFrom(bindings []*console.PolicyBindingFragment, config types.Set, c
 	return setValue
 }
 
-func BindingsFromReadOnly(bindings []*console.PolicyBindingFragment, ctx context.Context, d *diag.Diagnostics) types.Set {
+func BindingsFromReadOnly(bindings []*console.PolicyBindingFragment, planned types.Set, ctx context.Context, d *diag.Diagnostics) types.Set {
 	if len(bindings) == 0 {
-		return types.SetNull(types.ObjectType{AttrTypes: PolicyBindingAttrTypes})
+		// Rewriting planned to state to avoid inconsistent result errors.
+		// This could happen, for example, when sending "nil" to API and "[]" is returned as a result.
+		return planned
 	}
 
 	values := make([]attr.Value, len(bindings))

internal/model/cloud_connection.go

@@ -100,5 +100,4 @@ func (c *CloudConnection) From(cc *console.CloudConnectionFragment, ctx context.
 	c.Id = types.StringValue(cc.ID)
 	c.Name = types.StringValue(cc.Name)
 	c.CloudProvider = types.StringValue(string(cc.Provider))
-	c.ReadBindings = common.BindingsFromReadOnly(cc.ReadBindings, ctx, d)
 }

internal/resource/cloud_connection.go

@@ -86,7 +86,7 @@ func (r *CloudConnectionResource) Schema(_ context.Context, _ resource.SchemaReq
 						"id":       schema.StringAttribute{Optional: true},
 					},
 				},
-				PlanModifiers: []planmodifier.Set{setplanmodifier.UseStateForUnknown()},
+				PlanModifiers: []planmodifier.Set{setplanmodifier.RequiresReplace()},
 			},
 		},
 	}
@@ -109,7 +109,6 @@ func (r *CloudConnectionResource) gcpCloudConnectionAttrTypes() map[string]attr.
 
 func (r *CloudConnectionResource) azureCloudConnectionAttrTypes() map[string]attr.Type {
 	return map[string]attr.Type{
-
 		"subscription_id": types.StringType,
 		"tenant_id":       types.StringType,
 		"client_id":       types.StringType,