Skip to content

Commit 17803c5

Browse files
committed
Errata: fix a couple of spots in server upcall functions
Server upcall functions were required to return prior to executing the callback function. This was a limitation of the implementation and not a requirement of the Standard - the statements should never have been included here. FWIW: the limitation has subsequently been removed from the reference implementation. In the pmix_server_iof_fn_t, clarify that an error status can be returned either directly by the function or in the callback function. It does not require that the host execute the callback to return an error, as was implied by the current language. Signed-off-by: Ralph Castain <[email protected]>
1 parent 46c63a5 commit 17803c5

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

Chap_API_Server.tex

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ \subsection{\code{PMIx_server_deregister_resources}}
955955

956956
A \code{NULL} \refarg{cbfunc} reference indicates that the function is to be executed as a blocking operation.
957957
% TODO: If this is one of those functions that can be blocking or non-blocking, then
958-
% it needs a full return code explanation, not the returnsimple
958+
% it needs a full return code explanation, not the returnsimple
959959

960960
\advicermend
961961

@@ -3318,8 +3318,7 @@ \subsection{\code{pmix_server_tool_connection_fn_t}}
33183318
Approval or rejection of the connection request shall be returned in the
33193319
\refarg{status} parameter of the \refapi{pmix_tool_connection_cbfunc_t}. If
33203320
the connection is refused, the \ac{PMIx} server library must terminate the
3321-
connection attempt. The host must not execute the callback function prior to
3322-
returning from the \ac{API}.
3321+
connection attempt.
33233322

33243323
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
33253324
\subsubsection{Tool connection attributes}
@@ -3435,7 +3434,7 @@ \subsection{\code{pmix_server_log_fn_t}}
34353434
%%%%
34363435
\descr
34373436

3438-
Log data on behalf of a client. This function is not intended for output of computational results, but rather for reporting status and error messages. The host must not execute the callback function prior to returning from the \ac{API}.
3437+
Log data on behalf of a client. This function is not intended for output of computational results, but rather for reporting status and error messages.
34393438

34403439

34413440
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
@@ -3974,7 +3973,7 @@ \subsection{\code{pmix_server_iof_fn_t}}
39743973
%%%%
39753974
\descr
39763975

3977-
Request the specified IO channels be forwarded from the given array of processes. An error shall be returned in the callback function if the requested service from any of the requested processes cannot be provided.
3976+
Request the specified IO channels be forwarded from the given array of processes. An error shall be returned (either directly or in the callback function) if the requested service from any of the requested processes cannot be provided.
39783977

39793978
\adviceimplstart
39803979
The forwarding of stdin is a \textit{push} process - processes cannot request that it be \textit{pulled} from some other source. Requests including the \refconst{PMIX_FWD_STDIN_CHANNEL} channel will return a \refconst{PMIX_ERR_NOT_SUPPORTED} error.

0 commit comments

Comments
 (0)