Fixes

Author: dktapps

src/entity/object/FireworkRocket.php

@@ -124,7 +124,12 @@ protected function entityBaseTick(int $tickDiff = 1) : bool{
 		$hasUpdate = parent::entityBaseTick($tickDiff);
 
 		if(!$this->isFlaggedForDespawn()){
-			$this->addMotion($this->motion->x * 0.15, 0.04, $this->motion->z * 0.15);
+			//Don't keep accelerating long-lived fireworks - this gets very rapidly out of control and makes the server
+			//die vanilla fireworks will only live for about 52 ticks maximum anyway, so this only makes sure plugin
+			//created fireworks don't murder the server
+			if($this->ticksLived < 80){
+				$this->addMotion($this->motion->x * 0.15, 0.04, $this->motion->z * 0.15);
+			}
 
 			if($this->ticksLived >= $this->maxAgeTicks){
 				$this->flagForDespawn();

src/item/FireworkRocket.php

@@ -98,9 +98,13 @@ public function onInteractBlock(Player $player, Block $blockReplace, Block $bloc
 
 		$randomDuration = (($this->flightDurationMultiplier + 1) * 10) + mt_rand(0, 12);
 
-		$entity = new FireworkEntity(Location::fromObject($position, $player->getWorld(), lcg_value() * 360, 90), $randomDuration, $this->explosions);
+		$entity = new FireworkEntity(Location::fromObject($position, $player->getWorld(), Utils::getRandomFloat() * 360, 90), $randomDuration, $this->explosions);
 		$entity->setOwningEntity($player);
-		$entity->setMotion(new Vector3(lcg_value() * 0.001, 0.05, lcg_value() * 0.001));
+		$entity->setMotion(new Vector3(
+			(Utils::getRandomFloat() - Utils::getRandomFloat()) * 0.0023,
+			0.05,
+			(Utils::getRandomFloat() - Utils::getRandomFloat()) * 0.0023
+		));
 		$entity->spawnToAll();
 
 		$this->pop();