Skip to content

Commit b3bbb3f

Browse files
committed
Revert "remove errored tests :-p"
This reverts commit 88b5d6b.
1 parent 88b5d6b commit b3bbb3f

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tests/react/error.test.tsx

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,9 @@ describe('throws an error while updating in effect cleanup', () => {
465465

466466
fireEvent.click(screen.getByText('close'))
467467
if (reactVersion.startsWith('17.')) {
468-
// FIXME this fails since https://github.com/pmndrs/jotai/pull/3184
469-
//expect(
470-
// errorMessages.some((m) => m.includes('err_in_effect_cleanup')),
471-
//).toBe(true)
468+
expect(
469+
errorMessages.some((m) => m.includes('err_in_effect_cleanup')),
470+
).toBe(true)
472471
} else {
473472
expect(
474473
screen.getByText('Errored: err_in_effect_cleanup'),
@@ -494,10 +493,9 @@ describe('throws an error while updating in effect cleanup', () => {
494493

495494
fireEvent.click(screen.getByText('close'))
496495
if (reactVersion.startsWith('17.')) {
497-
// FIXME this fails since https://github.com/pmndrs/jotai/pull/3184
498-
//expect(
499-
// errorMessages.some((m) => m.includes('err_in_effect_cleanup')),
500-
//).toBe(true)
496+
expect(
497+
errorMessages.some((m) => m.includes('err_in_effect_cleanup')),
498+
).toBe(true)
501499
} else {
502500
expect(
503501
screen.getByText('Errored: err_in_effect_cleanup'),

0 commit comments

Comments
 (0)