fix(polyfills): migrate to new expo-file-system API for Expo 54

Author: alextoudic

package.json

@@ -69,7 +69,7 @@
     "eslint-plugin-react": "^7.29.4",
     "eslint-plugin-react-hooks": "^4.4.0",
     "expo-asset": "^8.6.0",
-    "expo-file-system": "^15.4.3",
+    "expo-file-system": "^19.0.17",
     "expo-gl": "^11.4.0",
     "husky": "^7.0.4",
     "jest": "^29.7.0",

packages/fiber/__mocks__/expo-file-system.ts

@@ -1,5 +1,8 @@
-export const EncodingType = { UTF8: 'utf8', Base64: 'base64' }
-export const cacheDirectory = 'file:///test/'
-export const readAsStringAsync = async () => ''
-export const writeAsStringAsync = async () => {}
-export const copyAsync = async () => {}
+export const Paths = { cache: { uri: 'file:///test/' } }
+export class File {
+  async write(data: string) {}
+  async base64() {
+    return ''
+  }
+  async copy(to: File) {}
+}

packages/fiber/src/native/polyfills.ts

@@ -46,8 +46,8 @@ async function getAsset(input: string | number): Promise<string> {
       const [header, data] = input.split(';base64,')
       const [, type] = header.split('/')
 
-      const uri = fs.cacheDirectory + uuidv4() + `.${type}`
-      await fs.writeAsStringAsync(uri, data, { encoding: fs.EncodingType.Base64 })
+      const uri = fs.Paths.cache.uri + uuidv4() + `.${type}`
+      await new fs.File(uri).write(data, { encoding: 'base64' })
 
       return uri
     }
@@ -59,8 +59,8 @@ async function getAsset(input: string | number): Promise<string> {
 
   // Unpack assets in Android Release Mode
   if (!uri.includes(':')) {
-    const file = `${fs.cacheDirectory}ExponentAsset-${asset.hash}.${asset.type}`
-    await fs.copyAsync({ from: uri, to: file })
+    const file = `${fs.Paths.cache.uri}ExponentAsset-${asset.hash}.${asset.type}`
+    await new fs.File(uri).copy(new fs.File(file))
     uri = file
   }
 
@@ -160,7 +160,7 @@ export function polyfills() {
 
     getAsset(url)
       .then(async (uri) => {
-        const base64 = await fs.readAsStringAsync(uri, { encoding: fs.EncodingType.Base64 })
+        const base64 = await new fs.File(uri).base64()
         const data = Buffer.from(base64, 'base64')
         onLoad?.(data.buffer)
       })

packages/fiber/tests/polyfills.test.ts

@@ -21,6 +21,8 @@ describe('polyfills', () => {
 
   it('unpacks drawables in Android APK', async () => {
     const texture = await new THREE.TextureLoader().loadAsync('drawable.png')
+    console.log('texture.image.data', texture.image.data)
+    console.log('texture.image.data.localUri', texture.image.data.localUri)
     expect(texture.image.data.localUri.includes(':')).toBe(true)
   })
 

yarn.lock

@@ -5155,7 +5155,12 @@ expo-constants@~15.3.0:
     "@expo/config" "~8.4.0"
     uuid "^3.3.2"
 
-expo-file-system@^15.4.3, expo-file-system@~15.9.0:
+expo-file-system@^19.0.17:
+  version "19.0.17"
+  resolved "https://registry.yarnpkg.com/expo-file-system/-/expo-file-system-19.0.17.tgz#2555c05c26a19038d005f281b11dbda9722d0c0d"
+  integrity sha512-WwaS01SUFrxBnExn87pg0sCTJjZpf2KAOzfImG0o8yhkU7fbYpihpl/oocXBEsNbj58a8hVt1Y4CVV5c1tzu/g==
+
+expo-file-system@~15.9.0:
   version "15.9.0"
   resolved "https://registry.yarnpkg.com/expo-file-system/-/expo-file-system-15.9.0.tgz#b048b9168875634efcce0aa002ee0eec31ed42a8"
   integrity sha512-ikzqBGpbSzp/57+aruXzRR2s0HEVYxdd1o3RxfswJRujjT/6X128xmUTTFDaQUr+zydyvxvY7Mo0szWpXhPyLA==