Skip to content

Commit 2bf90ea

Browse files
committed
All code refactored following PEP-8
1 parent 32e2d4b commit 2bf90ea

22 files changed

+45
-31
lines changed

apps/history/admin.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from django.contrib import admin
22
from apps.history.models import History
33

4-
admin.site.register(History)
54

5+
admin.site.register(History)

apps/history/features/steps.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from lettuce import step
22
from apps.history.models import History
33

4+
45
@step(u'Given current history is "(.*)"')
56
def given_current_history_is_group1(step, history_text):
67
History(text=history_text).save()
7-

apps/history/models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from django.db import models
22
from docutils.core import publish_parts
33

4+
45
class History(models.Model):
56
text = models.TextField(blank=False)
67
updated_at = models.DateTimeField(auto_now=True)
@@ -11,4 +12,3 @@ class Meta:
1112
def to_html(self):
1213
parts = publish_parts(source=self.text, writer_name="html4css1")
1314
return parts['fragment']
14-

apps/history/tests.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
from django.test import TestCase
2-
from should_dsl import *
2+
from should_dsl import should
33
from apps.history.models import History
44

5+
56
class HistoryTest(TestCase):
67

78
def test_convert_its_RST_text_to_HTML(self):
89
h = History(text="*NSI* site rulz!")
910
h.to_html() |should| contain('<em>NSI</em> site rulz!')
10-

apps/history/views.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from django.shortcuts import render_to_response
22
from apps.history.models import History
33

4+
45
def show(request):
56
return render_to_response('show.html',
6-
{ 'history': History.objects.all()[0] })
7-
7+
{'history': History.objects.all()[0]})

apps/members/features/steps.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@
33
from apps.members.models import Member
44
from lettuce.django import django_url
55

6+
67
@step(u'Given exist a member:')
78
def given_exist_a_member(step):
89
Member(**step.hashes[0]).save()
9-
10+
11+
1012
@step(r'I go to the "(.+)" member page')
1113
def i_go_to_member_page(step, member_name):
1214
member_obj = Member.objects.get(name=member_name)
1315
world.browser.visit(django_url('/member/%i' % member_obj.id))
14-

apps/members/models.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22
from apps.teams.models import Team
33
from apps.projects.models import Project
44

5+
56
class Member(models.Model):
67
name = models.CharField(max_length=100)
78
#current_team = models.ManyToManyField(Team)
89
current_team = models.CharField(max_length=100)
910
currently_does = models.TextField()
10-
life_and_work = models.TextField()
11+
life_and_work = models.TextField()
1112
site = models.URLField(null=True)
1213
github = models.URLField(null=True)
1314
twitter = models.URLField(null=True)

apps/members/views.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
from django.shortcuts import render_to_response
22
from apps.members.models import Member
33

4+
45
def show(request, member_id):
56
member = Member.objects.get(id=member_id)
67
return render_to_response('show_member.html',
7-
{ 'member': member})
8+
{'member': member})

apps/news/models.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
from django.db import models
22
from django.contrib.auth.models import User
33

4+
45
class News(models.Model):
56
title = models.CharField(max_length=200)
67
summary = models.CharField(max_length=200, null=True, blank=True)
78
body = models.TextField()
89
image = models.ImageField(null=True, blank=True, upload_to='images')
910
author = models.ForeignKey(User)
1011
datetime = models.DateTimeField(auto_now=True)
11-
12+
1213
class Meta:
1314
verbose_name_plural = 'News'
14-
15+
1516
def __unicode__(self):
1617
return self.title

apps/news/tests.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#encoding: utf-8
2-
1+
#-*- coding:utf-8 -*-
32
from django.test import TestCase
43

4+
55
class TestNews(TestCase):
6-
pass
6+
pass

apps/projects/admin.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from django.contrib import admin
22
from apps.projects.models import Project
33

4-
admin.site.register(Project)
54

5+
admin.site.register(Project)

apps/projects/features/steps.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
from lettuce import step, world
55
from apps.projects.models import Project
66

7+
78
@step(u'Given exist a project:')
89
def given_exist_a_project(step):
910
Project(**step.hashes[0]).save()
1011
file_name = step.hashes[0]['logo'].split('/')[-1]
1112
shutil.copy2(os.path.join(settings.PROJECT_ROOT_PATH, 'apps', 'projects',
1213
'features', 'resources', file_name),
1314
os.path.join(settings.MEDIA_ROOT, 'images', 'projects'))
14-

apps/projects/models.py

-1
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,3 @@ class Project(models.Model):
1919

2020
def finished(self):
2121
return self.end_date is not None
22-

apps/projects/tests.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
from should_dsl import should, should_not
33
from apps.projects.models import Project
44

5+
56
class ProjectTest(TestCase):
67
def test_finishing(self):
78
project = Project(start_date='2011-01-01', end_date=None)
89
project |should_not| be_finished
910
project.end_date = '2011-01-31'
1011
project |should| be_finished
11-

apps/projects/views.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from django.shortcuts import render_to_response
22
from apps.projects.models import Project
33

4+
45
def show_all(request):
56
projects = Project.objects.all()
67
return render_to_response('show_all_projects.html',
7-
{ 'projects': projects,
8-
'project_count': len(projects) })
9-
8+
{'projects': projects,
9+
'project_count': len(projects)})

manage.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/usr/bin/env python
22
from django.core.management import execute_manager
3+
34
try:
45
import settings # Assumed to be in the same directory.
56
except ImportError:

paths.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
from lettuce.django import django_url
22

3+
34
def path_to(page_name):
45
return django_url(
56
{
67
'the history page': '/history',
78
'the projects page': '/projects',
89
'the teams page': '/teams',
910
}[page_name])
10-

settings.py

-1
Original file line numberDiff line numberDiff line change
@@ -76,4 +76,3 @@
7676
'apps.teams',
7777
'apps.projects',
7878
)
79-

settings_test.py

-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@
1010
'PORT': '',
1111
}
1212
}
13-

terrain.py

+11-3
Original file line numberDiff line numberDiff line change
@@ -7,36 +7,44 @@
77
from lettuce import after, before, world
88
from web_steps import *
99

10+
1011
@before.all
1112
def set_browser():
1213
enable_selenium_specs_to_run_offline()
1314
world.browser = Browser()
1415

16+
1517
def enable_selenium_specs_to_run_offline():
1618
prefs = FirefoxProfile._get_webdriver_prefs()
1719
prefs['network.manage-offline-status'] = 'false'
20+
1821
@staticmethod
1922
def prefs_func():
2023
return prefs
2124
FirefoxProfile._get_webdriver_prefs = prefs_func
2225

26+
2327
@before.each_scenario
2428
def clean_database(scenario):
2529
clean_data()
2630
create_admin()
2731
clean_images()
2832

33+
2934
def clean_data():
30-
call_command('flush', interactive=False)
31-
call_command('loaddata', 'all')
35+
call_command('flush', interactive=False)
36+
call_command('loaddata', 'all')
37+
3238

3339
def create_admin():
3440
User.objects.create_superuser('admin', '[email protected]', 'admin')
3541

42+
3643
def clean_images():
3744
images_dir = os.path.join(settings.MEDIA_ROOT, 'images')
3845
clean_all(images_dir)
3946

47+
4048
def clean_all(directory):
4149
for file_name in os.listdir(directory):
4250
absname = os.path.join(directory, file_name)
@@ -45,8 +53,8 @@ def clean_all(directory):
4553
elif not file_name.startswith('.'):
4654
os.unlink(absname)
4755

56+
4857
@after.all
4958
def finish_him(total_result):
5059
world.browser.quit()
5160
clean_images()
52-

urls.py

-1
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,3 @@
1717

1818
(r'^site_media/(.*)$', 'django.views.static.serve', {"document_root": settings.MEDIA_ROOT}),
1919
)
20-

web_steps.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,30 +2,35 @@
22
from should_dsl import should
33
from paths import path_to
44

5+
56
@step(r'I fill in "(.*)" with "(.*)"')
67
def fill_field(step, label, value):
78
world.browser.fill_in(label, value)
89

10+
911
@step(r'I go to "(.+)"')
1012
def i_go_to(step, page_name):
1113
world.browser.visit(path_to(page_name))
1214

15+
1316
@step(r'I press "(.*)"')
1417
def press_button(step, name):
1518
world.browser.find_by_name(name.lower()).click()
1619

20+
1721
@step(r'I should see "(.*)"')
1822
def i_should_see(step, content):
1923
world.browser.html |should| contain(content)
2024

25+
2126
@step(u'I should have "(.*)" as HTML')
2227
def i_should_have_as_html(step, html_output):
2328
# different step descriptions for intention-revealing purposes
2429
step.then('I should see "%s"' % html_output)
2530

31+
2632
@step(u'I should see an image called "(.*)"')
2733
def and_i_should_see_an_image_called_group1(step, image_name):
2834
images = world.browser.find_by_css_selector('img')
2935
found_image = [image for image in images if image['src'].endswith(image_name)]
3036
found_image |should| have_at_least(1).image
31-

0 commit comments

Comments
 (0)