Skip to content

Commit 1c75d4b

Browse files
aingersonj-xiong
authored andcommitted
prov/psm3: fix logical atomic function calls
psm3 advertises support for logical ops (lor, land, lxor) with all datatypes but the functions are only defined for integer types. When the atomic op is called with a non-integer type, it drops down to the default case and returns an error (FI_ENOTSUPP) Signed-off-by: Alexia Ingerson <[email protected]>
1 parent f38320a commit 1c75d4b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

prov/psm3/src/psmx3_atomic.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,12 +401,12 @@ static int psmx3_atomic_do_write(void *dest, void *src,
401401
break;
402402

403403
case FI_LOR:
404-
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
404+
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
405405
dest,src,count,PSMX3_LOR);
406406
break;
407407

408408
case FI_LAND:
409-
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
409+
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
410410
dest,src,count,PSMX3_LAND);
411411
break;
412412

@@ -421,7 +421,7 @@ static int psmx3_atomic_do_write(void *dest, void *src,
421421
break;
422422

423423
case FI_LXOR:
424-
SWITCH_INT_TYPE(datatype,PSMX3_ATOMIC_WRITE,
424+
SWITCH_ALL_TYPE(datatype,PSMX3_ATOMIC_WRITE,
425425
dest,src,count,PSMX3_LXOR);
426426
break;
427427

0 commit comments

Comments
 (0)