fabtests: fix complex fill cast

The previous implementation was trying to fill complex numbers with
multiple chars in the integ_alphabet to randomize the data. Unfortunately,
this resulted in many complex numbers becoming invalid numbers (NaN).
Because of that, the data validation check would fail as NaN != NaN
To fix this, when filling the data, set the real and imaginary parts as
a single char element so the individual part is valid and can be used
in the computation and check.
Because the implementation of complex types differs on unix and Windows
systems, this requires the addition of a new function that initializes
the individual components of the complex number instead of the number
as a whole.

This requires moving the long_double typedef into the osd.h headers to
help with the casting.

Signed-off-by: Alexia Ingerson <[email protected]>

Author: aingerson

fabtests/include/ofi_atomic.h

@@ -40,7 +40,6 @@
 extern "C" {
 #endif
 
-typedef long double long_double;
 
 #define OFI_WRITE_OP_START	FI_MIN
 #define OFI_WRITE_OP_LAST	(FI_ATOMIC_WRITE + 1)

fabtests/include/shared.h

@@ -775,8 +775,8 @@ static inline void *ft_get_page_end(const void *addr, size_t page_size)
 		int i, a = 0;					\
 		OFI_COMPLEX(type) *d = (dst);			\
 		for (i = 0; i < cnt; i++) {			\
-			ofi_complex_set_##type (&d[i],		\
-				*(OFI_COMPLEX(type) *) &integ_alphabet[a]); \
+			ofi_complex_fill_##type (&d[i], 	\
+					(type) integ_alphabet[a]); \
 			if (++a >= integ_alphabet_length)	\
 				a = 0;				\
 		}						\

fabtests/include/unix/osd.h

@@ -83,6 +83,8 @@ static inline int ofi_sockerr(void)
 	return errno;
 }
 
+typedef long double long_double;
+
 /* complex operations implementation */
 #define OFI_COMPLEX(name) ofi_complex_##name
 #define OFI_COMPLEX_OP(name, op) ofi_complex_##op##_##name
@@ -120,6 +122,10 @@ static inline OFI_COMPLEX(name) OFI_COMPLEX_OP(name, lxor)(OFI_COMPLEX(name) v1,
 static inline void OFI_COMPLEX_OP(name, set)(OFI_COMPLEX(name) *v1, OFI_COMPLEX(name) v2)	      \
 {												      \
 	*v1 = v2;										      \
+}												      \
+static inline void OFI_COMPLEX_OP(name, fill)(OFI_COMPLEX(name) *v1, name v2)			      \
+{												      \
+	*v1 = CMPLX(v2, v2);							  		      \
 }
 
 OFI_COMPLEX_OPS(float)

fabtests/include/windows/osd.h

@@ -724,6 +724,7 @@ ofi_send_socket(SOCKET fd, const void *buf, size_t count, int flags)
 	return (ssize_t) send(fd, (const char*) buf, len, flags);
 }
 
+typedef long double long_double;
 
 /* complex operations implementation */
 #define OFI_COMPLEX(name) ofi_complex_##name
@@ -790,6 +791,11 @@ static inline void OFI_COMPLEX_OP(name, set)(OFI_COMPLEX(name) *v1, OFI_COMPLEX(
 {											\
 	v1->re = v2.re;									\
 	v1->im = v2.im;									\
+}											\
+static inline void OFI_COMPLEX_OP(name, fill)(OFI_COMPLEX(name) *v1, char v2)		\
+{											\
+	v1->re = v2;									\
+	v1->im = v2;									\
 }
 
 OFI_COMPLEX_OPS(float)