Skip to content

Commit 27a9152

Browse files
authored
Merge pull request #7273 from raffenet/macos-static-4.3.x
[4.3.x] macos: Fix static build with embedded hwloc
2 parents 4f08552 + f133f04 commit 27a9152

File tree

8 files changed

+10
-8
lines changed

8 files changed

+10
-8
lines changed

confdb/aclocal_modules.m4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ AC_DEFUN([PAC_CONFIG_HWLOC],[
139139
if test -n "$hwloc_darwin_ldflags" ; then
140140
echo "hwloc_darwin_ldflags = $hwloc_darwin_ldflags"
141141
PAC_APPEND_FLAG([$hwloc_darwin_ldflags], [LDFLAGS])
142+
# we also need these flags for linking in the wrapper scripts
143+
PAC_APPEND_FLAG([$hwloc_darwin_ldflags], [WRAPPER_DEPENDENCY_LDFLAGS])
142144
fi
143145
fi
144146
])

configure.ac

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,8 @@ FFLAGS="$FFLAGS $MPICHLIB_FFLAGS"
313313
FCFLAGS="$FCFLAGS $MPICHLIB_FCFLAGS"
314314
# Save LDFLAGS before merging with MPICHLIB_LDFLAGS. The wrapper scripts
315315
# may need this in case interlibrary dependencies are not supported.
316-
SAVE_LDFLAGS=$LDFLAGS
317-
AC_SUBST(SAVE_LDFLAGS)
316+
WRAPPER_DEPENDENCY_LDFLAGS=$LDFLAGS
317+
AC_SUBST(WRAPPER_DEPENDENCY_LDFLAGS)
318318
LDFLAGS="$LDFLAGS $MPICHLIB_LDFLAGS"
319319
LIBS="$LIBS $MPICHLIB_LIBS"
320320

src/env/mpicc.bash.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ final_cppflags="@MPICH_MPICC_CPPFLAGS@ @WRAPPER_CPPFLAGS@"
262262
final_ldflags="@MPICH_MPICC_LDFLAGS@ @WRAPPER_LDFLAGS@"
263263
final_libs="@MPICH_MPICC_LIBS@"
264264
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
265-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
265+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
266266
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
267267
fi
268268

src/env/mpicc.sh.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ final_cppflags="@MPICH_MPICC_CPPFLAGS@ @WRAPPER_CPPFLAGS@"
268268
final_ldflags="@MPICH_MPICC_LDFLAGS@ @WRAPPER_LDFLAGS@"
269269
final_libs="@MPICH_MPICC_LIBS@"
270270
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
271-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
271+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
272272
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
273273
fi
274274

src/env/mpicxx.bash.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ final_cppflags="@MPICH_MPICXX_CPPFLAGS@ @WRAPPER_CPPFLAGS@"
267267
final_ldflags="@MPICH_MPICXX_LDFLAGS@ @WRAPPER_LDFLAGS@"
268268
final_libs="@MPICH_MPICXX_LIBS@"
269269
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
270-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
270+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
271271
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
272272
fi
273273

src/env/mpicxx.sh.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ final_cppflags="@MPICH_MPICXX_CPPFLAGS@ @WRAPPER_CPPFLAGS@"
273273
final_ldflags="@MPICH_MPICXX_LDFLAGS@ @WRAPPER_LDFLAGS@"
274274
final_libs="@MPICH_MPICXX_LIBS@"
275275
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
276-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
276+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
277277
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
278278
fi
279279

src/env/mpifort.bash.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ final_fcflags="@MPICH_MPIFORT_FCFLAGS@ @WRAPPER_FCFLAGS@"
339339
final_ldflags="@MPICH_MPIFORT_LDFLAGS@ @WRAPPER_LDFLAGS@"
340340
final_libs="@MPICH_MPIFORT_LIBS@"
341341
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
342-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
342+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
343343
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
344344
fi
345345

src/env/mpifort.sh.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ final_fcflags="@MPICH_MPIFORT_FCFLAGS@ @WRAPPER_FCFLAGS@"
356356
final_ldflags="@MPICH_MPIFORT_LDFLAGS@ @WRAPPER_LDFLAGS@"
357357
final_libs="@MPICH_MPIFORT_LIBS@"
358358
if test "@INTERLIB_DEPS@" = "no" -o "${interlib_deps}" = "no" ; then
359-
final_ldflags="${final_ldflags} @SAVE_LDFLAGS@"
359+
final_ldflags="${final_ldflags} @WRAPPER_DEPENDENCY_LDFLAGS@"
360360
final_libs="${final_libs} __LIBS_TO_BE_FILLED_AT_INSTALL_TIME__"
361361
fi
362362

0 commit comments

Comments
 (0)