misc: Replace sprintf usage with snprintf

raffenet · raffenet · commit 50b0aef3a1ea · 2025-06-09T13:05:53.000-05:00
Modern toolchains are warning that sprintf is deprecated and unsafe to
use. Replace all usage with snprintf to eliminate those warnings.
diff --git a/src/mpi/coll/algorithms/treealgo/treealgo.c b/src/mpi/coll/algorithms/treealgo/treealgo.c
@@ -228,7 +228,7 @@ static void dump_node(MPIR_Treealgo_tree_t * node, FILE * output_stream)
 static void dump_tree(int tree_type, int rank, MPIR_Treealgo_tree_t * ct)
 {
     char outfile_name[PATH_MAX];
-    sprintf(outfile_name, "%s%d.json", "colltree", rank);
+    snprintf(outfile_name, sizeof(outfile_name), "%s%d.json", "colltree", rank);
     fprintf(stdout, "tree_type=%d: dumping %s\n", tree_type, outfile_name);
     FILE *outfile = fopen(outfile_name, "w");
     dump_node(ct, outfile);
diff --git a/src/mpi/coll/algorithms/treealgo/treeutil.c b/src/mpi/coll/algorithms/treealgo/treeutil.c
@@ -556,7 +556,7 @@ static int MPII_Treeutil_hierarchy_populate(MPIR_Comm * comm, int rank, int nran
     /* Dump hierarchy for debugging */
     if (MPIR_CVAR_HIERARCHY_DUMP) {
         char outfile_name[PATH_MAX];
-        sprintf(outfile_name, "%s%d", "hierarchy", rank);
+        snprintf(outfile_name, sizeof(outfile_name), "%s%d", "hierarchy", rank);
         FILE *outfile = fopen(outfile_name, "w");
         tree_topology_dump_hierarchy(hierarchy, rank, outfile);
         fclose(outfile);
diff --git a/src/mpi/romio/adio/common/ad_set_view.c b/src/mpi/romio/adio/common/ad_set_view.c
@@ -17,15 +17,15 @@ int check_type(ADIOI_Flatlist_node * flat_type,
     /* MPI standard requires the displacements of etype and filetype be
      * non-negative */
     if (flat_type->flag & ADIOI_TYPE_NEGATIVE) {
-        sprintf(err_msg, "displacements of %s must be non-negative", type_kind);
+        snprintf(err_msg, sizeof(err_msg), "displacements of %s must be non-negative", type_kind);
         goto err_check;
     }
 
     /* MPI standard requires the displacements of etype and filetype be in a
      * monotonically nondecreasing order */
     if (flat_type->flag & ADIOI_TYPE_DECREASE) {
-        sprintf(err_msg, "displacements of %s must be in a monotonically nondecreasing order",
-                type_kind);
+        snprintf(err_msg, sizeof(err_msg),
+                 "displacements of %s must be in a monotonically nondecreasing order", type_kind);
         goto err_check;
     }
 
@@ -34,7 +34,8 @@ int check_type(ADIOI_Flatlist_node * flat_type,
      */
     if (((access_mode & ADIO_WRONLY) || (access_mode & ADIO_RDWR)) &&
         (flat_type->flag & ADIOI_TYPE_OVERLAP)) {
-        sprintf(err_msg, "%s is not permitted to contain overlapping regions", type_kind);
+        snprintf(err_msg, sizeof(err_msg), "%s is not permitted to contain overlapping regions",
+                 type_kind);
         goto err_check;
     }
 
diff --git a/src/mpi/romio/test/async-multiple.c b/src/mpi/romio/test/async-multiple.c
@@ -72,7 +72,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     errcode = MPI_File_open(MPI_COMM_SELF, filename,
                             MPI_MODE_CREATE | MPI_MODE_RDWR, MPI_INFO_NULL, &fh);
diff --git a/src/mpi/romio/test/async.c b/src/mpi/romio/test/async.c
@@ -70,7 +70,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     errcode = MPI_File_open(MPI_COMM_SELF, filename,
                             MPI_MODE_CREATE | MPI_MODE_RDWR, MPI_INFO_NULL, &fh);
diff --git a/src/mpi/romio/test/error.c b/src/mpi/romio/test/error.c
@@ -72,7 +72,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     MPI_CHECK(MPI_File_open(MPI_COMM_SELF, filename, MPI_MODE_CREATE + MPI_MODE_RDWR,
                             MPI_INFO_NULL, &fh));
diff --git a/src/mpi/romio/test/file_info.c b/src/mpi/romio/test/file_info.c
@@ -251,7 +251,7 @@ int main(int argc, char **argv)
     MPI_Info_set(info, "cb_buffer_size", "8388608");
 
     /* number of processes that actually perform I/O in collective I/O */
-    sprintf(value, "%d", nprocs / 2);
+    snprintf(value, sizeof(value), "%d", nprocs / 2);
     MPI_Info_set(info, "cb_nodes", value);
 
     /* buffer size for data sieving in independent reads */
@@ -270,7 +270,7 @@ int main(int argc, char **argv)
      * If not set by the file system, the default value is 0.
      */
     if (default_striping_factor > 0) {
-        sprintf(value, "%d", default_striping_factor);
+        snprintf(value, sizeof(value), "%d", default_striping_factor);
         MPI_Info_set(info, "striping_factor", value);
     }
 
@@ -286,7 +286,7 @@ int main(int argc, char **argv)
      * accepted only if 0 <= value < default_striping_factor - 1
      * ignored otherwise */
     if (default_striping_factor > 1)
-        sprintf(value, "%d", default_striping_factor - 2);
+        snprintf(value, sizeof(value), "%d", default_striping_factor - 2);
     else
         strcpy(value, "0");
     MPI_Info_set(info, "start_iodevice", value);
diff --git a/src/mpi/romio/test/fstype_prefix.c b/src/mpi/romio/test/fstype_prefix.c
@@ -164,7 +164,7 @@ int main(int argc, char **argv)
     }
 
     /* test a file system type prefix unknown to ROMIO */
-    sprintf(out_fname, "nosuch_fstype:%s.out", filename);
+    snprintf(out_fname, sizeof(out_fname), "nosuch_fstype:%s.out", filename);
     if (verbose && rank == 0)
         fprintf(stdout, "Testing file name prefix (unknown to ROMIO): %s", out_fname);
     err = MPI_File_open(MPI_COMM_WORLD, out_fname, MPI_MODE_CREATE | MPI_MODE_RDWR,
@@ -190,7 +190,7 @@ int main(int argc, char **argv)
     MPI_Barrier(MPI_COMM_WORLD);
 
     /* test a file system type prefix known to ROMIO and enabled at configure */
-    sprintf(out_fname, "%s%s.out", enabled_prefix, filename);
+    snprintf(out_fname, sizeof(out_fname), "%s%s.out", enabled_prefix, filename);
     if (verbose && rank == 0)
         fprintf(stdout, "Testing file name prefix (known and enabled): %s", enabled_prefix);
     err = MPI_File_open(MPI_COMM_WORLD, out_fname, MPI_MODE_CREATE | MPI_MODE_RDWR,
@@ -204,7 +204,7 @@ int main(int argc, char **argv)
     MPI_Barrier(MPI_COMM_WORLD);
 
     /* strip the known prefix */
-    sprintf(out_fname, "%s.out", filename);
+    snprintf(out_fname, sizeof(out_fname), "%s.out", filename);
     err = check_file_exist(out_fname);
     if (err != 0)
         goto err_out;
@@ -219,7 +219,7 @@ int main(int argc, char **argv)
 
     /* set a known file system type prefix to ROMIO in environment variable ROMIO_FSTYPE_FORCE */
     setenv("ROMIO_FSTYPE_FORCE", enabled_prefix, 1);
-    sprintf(out_fname, "%s.out", filename);
+    snprintf(out_fname, sizeof(out_fname), "%s.out", filename);
     if (verbose && rank == 0)
         fprintf(stdout, "Testing ROMIO_FSTYPE_FORCE prefix (known and enabled): %s",
                 enabled_prefix);
@@ -246,7 +246,7 @@ int main(int argc, char **argv)
     MPI_Barrier(MPI_COMM_WORLD);
 
     /* test a file system type prefix known to ROMIO but disabled at configure */
-    sprintf(out_fname, "%s%s.out", disabled_prefix, filename);
+    snprintf(out_fname, sizeof(out_fname), "%s%s.out", disabled_prefix, filename);
     if (verbose && rank == 0)
         fprintf(stdout, "Testing file name prefix (known but disabled): %s", disabled_prefix);
     err = MPI_File_open(MPI_COMM_WORLD, out_fname, MPI_MODE_CREATE | MPI_MODE_RDWR,
@@ -259,7 +259,7 @@ int main(int argc, char **argv)
 
     /* set a known file system type prefix to ROMIO in environment variable ROMIO_FSTYPE_FORCE */
     setenv("ROMIO_FSTYPE_FORCE", disabled_prefix, 1);
-    sprintf(out_fname, "%s.out", filename);
+    snprintf(out_fname, sizeof(out_fname), "%s.out", filename);
     if (verbose && rank == 0)
         fprintf(stdout, "Testing ROMIO_FSTYPE_FORCE prefix (known but disabled): %s",
                 disabled_prefix);
diff --git a/src/mpi/romio/test/psimple.c b/src/mpi/romio/test/psimple.c
@@ -73,7 +73,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     MPI_CHECK(PMPI_File_open(MPI_COMM_SELF, filename,
                              MPI_MODE_CREATE | MPI_MODE_RDWR, MPI_INFO_NULL, &fh));
diff --git a/src/mpi/romio/test/simple.c b/src/mpi/romio/test/simple.c
@@ -67,7 +67,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     errcode = MPI_File_open(MPI_COMM_SELF, filename,
                             MPI_MODE_CREATE | MPI_MODE_RDWR, MPI_INFO_NULL, &fh);
diff --git a/src/mpi/romio/test/status.c b/src/mpi/romio/test/status.c
@@ -65,7 +65,7 @@ int main(int argc, char **argv)
     /* each process opens a separate file called filename.'myrank' */
     tmp = (char *) malloc(len + 10);
     strcpy(tmp, filename);
-    sprintf(filename, "%s.%d", tmp, rank);
+    snprintf(filename, len + 10, "%s.%d", tmp, rank);
 
     MPI_CHECK(MPI_File_open(MPI_COMM_SELF, filename,
                             MPI_MODE_CREATE | MPI_MODE_RDWR, MPI_INFO_NULL, &fh));
diff --git a/src/mpi/session/session_impl.c b/src/mpi/session/session_impl.c
@@ -193,7 +193,7 @@ int MPIR_Session_get_pset_info_impl(MPIR_Session * session_ptr, const char *pset
     }
 
     char buf[20];
-    sprintf(buf, "%d", mpi_size);
+    snprintf(buf, sizeof(buf), "%d", mpi_size);
     mpi_errno = MPIR_Info_set_impl(*info_p_p, "mpi_size", buf);
     MPIR_ERR_CHECK(mpi_errno);
 
diff --git a/src/mpid/ch4/netmod/ofi/init_provider.c b/src/mpid/ch4/netmod/ofi/init_provider.c
@@ -240,29 +240,29 @@ static const char *get_prov_addr(struct fi_info *prov)
     char addr_buf[500];
     switch (prov->addr_format) {
         case FI_SOCKADDR_IN:
-            sprintf(addr_str, "FI_SOCKADDR_IN [%zd] %s", prov->src_addrlen,
-                    inet_ntoa(((struct sockaddr_in *) prov->src_addr)->sin_addr));
+            snprintf(addr_str, sizeof(addr_str), "FI_SOCKADDR_IN [%zd] %s", prov->src_addrlen,
+                     inet_ntoa(((struct sockaddr_in *) prov->src_addr)->sin_addr));
             break;
         case FI_SOCKADDR_IN6:
-            sprintf(addr_str, "FI_SOCKADDR_IN6 [%zd] %s", prov->src_addrlen,
-                    inet_ntop(AF_INET6, &((struct sockaddr_in6 *) prov->src_addr)->sin6_addr,
-                              addr_buf, 500));
+            snprintf(addr_str, sizeof(addr_str), "FI_SOCKADDR_IN6 [%zd] %s", prov->src_addrlen,
+                     inet_ntop(AF_INET6, &((struct sockaddr_in6 *) prov->src_addr)->sin6_addr,
+                               addr_buf, 500));
             break;
         case FI_SOCKADDR_IB:
-            sprintf(addr_str, "FI_SOCKADDR_IB [%zd]", prov->src_addrlen);
+            snprintf(addr_str, sizeof(addr_str), "FI_SOCKADDR_IB [%zd]", prov->src_addrlen);
             break;
         case FI_ADDR_PSMX:
-            sprintf(addr_str, "FI_ADDR_PSMX [%zd]", prov->src_addrlen);
+            snprintf(addr_str, sizeof(addr_str), "FI_ADDR_PSMX [%zd]", prov->src_addrlen);
             break;
         case FI_ADDR_GNI:
-            sprintf(addr_str, "FI_ADDR_GNI [%zd]", prov->src_addrlen);
+            snprintf(addr_str, sizeof(addr_str), "FI_ADDR_GNI [%zd]", prov->src_addrlen);
             break;
         case FI_ADDR_STR:
-            snprintf(addr_str, 1024, "FI_ADDR_STR [%zd] - %s", prov->src_addrlen,
+            snprintf(addr_str, sizeof(addr_str), "FI_ADDR_STR [%zd] - %s", prov->src_addrlen,
                      (char *) prov->src_addr);
             break;
         default:
-            sprintf(addr_str, "FI_FORMAT_UNSPEC [%zd]", prov->src_addrlen);
+            snprintf(addr_str, sizeof(addr_str), "FI_FORMAT_UNSPEC [%zd]", prov->src_addrlen);
     }
     return addr_str;
 }
diff --git a/src/mpid/ch4/shm/src/topotree.c b/src/mpid/ch4/shm/src/topotree.c
@@ -170,13 +170,13 @@ void MPIDI_SHM_copy_tree(int *shared_region, int num_ranks, int rank,
     MPIR_Assert(my_tree->children);
     utarray_reserve(my_tree->children, num_children, MPL_MEM_COLL);
     char str[1024], tmp[128];
-    sprintf(str, "----**Rank %d, Parent, %d, Child(%d)[", rank, parent, num_children);
+    snprintf(str, sizeof(str), "----**Rank %d, Parent, %d, Child(%d)[", rank, parent, num_children);
     for (int c = 0; c < num_children; ++c) {
         utarray_push_back(my_tree->children, &my_children[c], MPL_MEM_COLL);
         if (my_children[c] == 0) {
             *topotree_fail = 1;
         }
-        sprintf(tmp, "%d, ", my_children[c]);
+        snprintf(tmp, sizeof(tmp), "%d, ", my_children[c]);
         strcat(str, tmp);
         my_tree->num_children++;
     }
@@ -433,10 +433,10 @@ int MPIDI_SHM_gen_tree(int k_val, int *shared_region, int *max_entries_per_level
     if (MPIDI_SHM_TOPOTREE_DEBUG) {
         char str[1024], tmp[128];
         for (i = 0; i < num_ranks; ++i) {
-            sprintf(str, "*BaseTreeRank %d, parent %d, children=%d [", i,
-                    MPIDI_SHM_TOPOTREE_PARENT(&tree, i), MPIDI_SHM_TOPOTREE_NUM_CHILD(&tree, i));
+            snprintf(str, sizeof(str), "*BaseTreeRank %d, parent %d, children=%d [", i,
+                     MPIDI_SHM_TOPOTREE_PARENT(&tree, i), MPIDI_SHM_TOPOTREE_NUM_CHILD(&tree, i));
             for (j = 0; j < MPIDI_SHM_TOPOTREE_NUM_CHILD(&tree, i); ++j) {
-                sprintf(tmp, "%d, ", MPIDI_SHM_TOPOTREE_CHILD(&tree, i, j));
+                snprintf(tmp, sizeof(tmp), "%d, ", MPIDI_SHM_TOPOTREE_CHILD(&tree, i, j));
                 strcat(str, tmp);
             }
             fprintf(stderr, "%s]\n", str);
diff --git a/src/mpid/ch4/shm/src/topotree_util.c b/src/mpid/ch4/shm/src/topotree_util.c
@@ -34,7 +34,7 @@ void MPIDI_SHM_print_topotree_file(const char *s, int rand_val, int rank,
     char fname[256];
     int c;
 
-    sprintf(fname, "FILE_%s_%d__%d_%d_.tree", s, rand_val, getpid(), rank);
+    snprintf(fname, sizeof(fname), "FILE_%s_%d__%d_%d_.tree", s, rand_val, getpid(), rank);
     file = fopen(fname, "w");
     if (file) {
         fprintf(file, "Children:: ");
diff --git a/src/mpl/src/gpu/mpl_gpu_cuda.c b/src/mpl/src/gpu/mpl_gpu_cuda.c
@@ -52,7 +52,7 @@ int MPL_gpu_get_dev_list(int *dev_count, char ***dev_list, bool is_subdev)
     for (int i = 0; i < device_count; ++i) {
         int str_len = snprintf(NULL, 0, "%d", i);
         device_list[i] = (char *) MPL_malloc((str_len + 1) * sizeof(char *), MPL_MEM_OTHER);
-        sprintf(device_list[i], "%d", i);
+        snprintf(device_list[i], str_len + 1, "%d", i);
     }
 
     *dev_count = device_count;
diff --git a/src/mpl/src/gpu/mpl_gpu_hip.c b/src/mpl/src/gpu/mpl_gpu_hip.c
@@ -47,7 +47,7 @@ int MPL_gpu_get_dev_list(int *dev_count, char ***dev_list, bool is_subdev)
     for (int i = 0; i < device_count; ++i) {
         int str_len = snprintf(NULL, 0, "%d", i);
         device_list[i] = (char *) MPL_malloc((str_len + 1) * sizeof(char *), MPL_MEM_OTHER);
-        sprintf(device_list[i], "%d", i);
+        snprintf(device_list[i], str_len + 1, "%d", i);
     }
 
     *dev_list = device_list;
diff --git a/src/mpl/src/gpu/mpl_gpu_ze.c b/src/mpl/src/gpu/mpl_gpu_ze.c
@@ -273,7 +273,7 @@ int MPL_gpu_get_dev_list(int *dev_count, char ***dev_list, bool is_subdev)
         for (int i = 0; i < device_count; ++i) {
             int str_len = snprintf(NULL, 0, "%d", i);
             device_list[i] = (char *) MPL_malloc((str_len + 1) * sizeof(char *), MPL_MEM_OTHER);
-            sprintf(device_list[i], "%d", i);
+            snprintf(device_list[i], str_len + 1, "%d", i);
         }
 
         *dev_count = device_count;
@@ -335,7 +335,7 @@ int MPL_gpu_get_dev_list(int *dev_count, char ***dev_list, bool is_subdev)
                 int str_len = snprintf(NULL, 0, "%d.%d", i, j);
                 device_list[idx] =
                     (char *) MPL_malloc((str_len + 1) * sizeof(char *), MPL_MEM_OTHER);
-                sprintf(device_list[idx], "%d.%d", i, j);
+                snprintf(device_list[idx], str_len + 1, "%d.%d", i, j);
                 device_list[idx][str_len] = 0;
                 idx++;
             }
@@ -1185,7 +1185,7 @@ static int gpu_ze_init_driver(void)
             strcpy(uuid_str, "uuid: ");
             for (int j = 0; j < ZE_MAX_DRIVER_UUID_SIZE; j++) {
                 char s[128];
-                sprintf(s, "%x ", device_properties.uuid.id[j]);
+                snprintf(s, sizeof(s), "%x ", device_properties.uuid.id[j]);
                 strcat(uuid_str, s);
             }
             fprintf(stderr, "  %s\n", uuid_str);
diff --git a/src/util/mpir_pmi.c b/src/util/mpir_pmi.c
@@ -433,7 +433,7 @@ static int put_ex_segs(const char *key, const void *buf, int bufsize, int is_loc
         MPIR_ERR_CHECK(mpi_errno);
         for (int i = 0; i < num_segs; i++) {
             char seg_key[50];
-            sprintf(seg_key, "%s-seg-%d/%d", key, i + 1, num_segs);
+            snprintf(seg_key, sizeof(seg_key), "%s-seg-%d/%d", key, i + 1, num_segs);
             int n = segsize;
             if (i == num_segs - 1) {
                 n = bufsize - segsize * (num_segs - 1);
@@ -472,7 +472,7 @@ static int get_ex_segs(int src, const char *key, void *buf, int *p_size, int is_
         got_size = 0;
         for (int i = 0; i < num_segs; i++) {
             char seg_key[50];
-            sprintf(seg_key, "%s-seg-%d/%d", key, i + 1, num_segs);
+            snprintf(seg_key, sizeof(seg_key), "%s-seg-%d/%d", key, i + 1, num_segs);
             mpi_errno = optimized_get(src, seg_key, val, pmi_max_val_size, is_local);
             MPIR_ERR_CHECK(mpi_errno);
             rc = MPL_hex_decode(val, (char *) buf + i * segsize, bufsize - i * segsize, &len_out);
@@ -588,7 +588,7 @@ int MPIR_pmi_bcast(void *buf, int bufsize, MPIR_PMI_DOMAIN domain)
         }
         /* add root to the key since potentially we may have multiple root(s)
          * on a single node due to odd-even-cliques */
-        sprintf(key, "-bcast-%d-%d", bcast_seq, root);
+        snprintf(key, sizeof(key), "-bcast-%d-%d", bcast_seq, root);
 
         if (is_root) {
             mpi_errno = put_ex(key, buf, bufsize, is_local);
@@ -629,7 +629,7 @@ int MPIR_pmi_allgather(const void *sendbuf, int sendsize, void *recvbuf, int rec
     allgather_seq++;
 
     char key[50];
-    sprintf(key, "-allgather-%d-%d", allgather_seq, MPIR_Process.rank);
+    snprintf(key, sizeof(key), "-allgather-%d-%d", allgather_seq, MPIR_Process.rank);
 
     if (in_domain) {
         mpi_errno = put_ex(key, sendbuf, sendsize, 0);
@@ -650,7 +650,7 @@ int MPIR_pmi_allgather(const void *sendbuf, int sendsize, void *recvbuf, int rec
             if (domain == MPIR_PMI_DOMAIN_NODE_ROOTS) {
                 rank = MPIR_Process.node_root_map[i];
             }
-            sprintf(key, "-allgather-%d-%d", allgather_seq, rank);
+            snprintf(key, sizeof(key), "-allgather-%d-%d", allgather_seq, rank);
             int got_size = recvsize;
             mpi_errno = get_ex(rank, key, (unsigned char *) recvbuf + i * recvsize, &got_size, 0);
             MPIR_ERR_CHECK(mpi_errno);
@@ -688,7 +688,7 @@ int MPIR_pmi_allgather_shm(const void *sendbuf, int sendsize, void *shm_buf, int
     allgather_shm_seq++;
 
     char key[50];
-    sprintf(key, "-allgather-shm-%d-%d", allgather_shm_seq, rank);
+    snprintf(key, sizeof(key), "-allgather-shm-%d-%d", allgather_shm_seq, rank);
 
     /* in roots-only, non-roots would skip the put */
     if (domain != MPIR_PMI_DOMAIN_NODE_ROOTS || is_node_root) {
@@ -717,7 +717,7 @@ int MPIR_pmi_allgather_shm(const void *sendbuf, int sendsize, void *shm_buf, int
         if (domain == MPIR_PMI_DOMAIN_NODE_ROOTS) {
             src = MPIR_Process.node_root_map[i];
         }
-        sprintf(key, "-allgather-shm-%d-%d", allgather_shm_seq, src);
+        snprintf(key, sizeof(key), "-allgather-shm-%d-%d", allgather_shm_seq, src);
         int got_size = recvsize;
         mpi_errno = get_ex(src, key, (unsigned char *) shm_buf + i * recvsize, &got_size, 0);
         MPIR_ERR_CHECK(mpi_errno);

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ static void dump_node(MPIR_Treealgo_tree_t * node, FILE * output_stream)`
`228`	`228`	`static void dump_tree(int tree_type, int rank, MPIR_Treealgo_tree_t * ct)`
`229`	`229`	`{`
`230`	`230`	`char outfile_name[PATH_MAX];`
`231`		`- sprintf(outfile_name, "%s%d.json", "colltree", rank);`
	`231`	`+ snprintf(outfile_name, sizeof(outfile_name), "%s%d.json", "colltree", rank);`
`232`	`232`	`fprintf(stdout, "tree_type=%d: dumping %s\n", tree_type, outfile_name);`
`233`	`233`	`FILE *outfile = fopen(outfile_name, "w");`
`234`	`234`	`dump_node(ct, outfile);`