hcoll: Fix initialization

Always set is_hcoll_init to 0 at the start of initialization to ensure
an uninitialized value is never mistakenly used to invoke hcoll.

Author: raffenet

src/mpid/common/hcoll/hcoll_init.c

@@ -130,28 +130,27 @@ int hcoll_comm_create(MPIR_Comm * comm_ptr, void *param)
     int context_destroyed;
     mpi_errno = MPI_SUCCESS;
 
+    comm_ptr->hcoll_priv.is_hcoll_init = 0;
+
     if (0 == hcoll_initialized) {
         mpi_errno = hcoll_initialize();
         MPIR_ERR_CHECK(mpi_errno);
     }
 
     if (0 == hcoll_enable) {
-        comm_ptr->hcoll_priv.is_hcoll_init = 0;
         goto fn_exit;
     }
 
     if (MPIR_Process.comm_world == comm_ptr) {
         hcoll_comm_world_initialized = 1;
     }
     if (!hcoll_comm_world_initialized) {
-        comm_ptr->hcoll_priv.is_hcoll_init = 0;
         goto fn_exit;
     }
     num_ranks = comm_ptr->local_size;
     if ((MPIR_COMM_KIND__INTRACOMM != comm_ptr->comm_kind) || (2 > num_ranks)
         || comm_ptr->hierarchy_kind == MPIR_COMM_HIERARCHY_KIND__NODE_ROOTS
         || comm_ptr->hierarchy_kind == MPIR_COMM_HIERARCHY_KIND__NODE) {
-        comm_ptr->hcoll_priv.is_hcoll_init = 0;
         goto fn_exit;
     }