schema_utils.py KeyError

[JacksonJ-KC]

Creating this issue for tracking purposes. I think this may be related to schema version updates. I can't spend much more time looking into this at the moment.

line 219, in return_json_schema_reference
return properties_dict["items"]["$ref"].split("/")[-1]
KeyError: '$ref'

Variables in debug:

key = 'primary_layers'
properties_dict = {
    'description': 'List of names, or IDs, of layer descriptions starting from the outside surface for primary heat path',
    'items': {}, 
    'notes': 'For constructions with framing and cavity heat transfer paths, use this for the cavity. For constructions with homogeneous layer, use this element only. Air films should not be included in the list of layers. When Construction.primary_layers are specified, the Construction.r_values should not be used. The list of primary_layers should include at least one Material that has mass with Material.density and Material.specific_heat specified. A list of material data groups can either appear here or a list of references to IDs of a Materials already defined somewhere else or a mixture of both. When a reference is used, the constraint to use when implemented is to :Material:', 
    'type': 'array'
}

[jugonzal07]

Thanks Jackson--

What is it that you were running that generated this? I have to update this function from time to time as I update XML version schemas. This makes me wonder if this was related to a primary_layer property with a unit being looked up but I'm not sure from where. The primary_layers JSON path gets updated in 0.1.7 as well.

[JacksonJ-KC]

Encountered while running the code below:

from rct229.web_application import run_project_evaluation as run
from rct229.utils.file import deserialize_rpd_file

rpd_path = r"MY_RPD_PATH"
rpd = None

try:
    rpd = deserialize_rpd_file(rpd_path)
except:
    print(f"{rpd_path} is not a valid JSON file")


run([rpd], "ashrae9012019", ["ASHRAE9012019DetailReport"])

[weilixu]

I updated this part in the schema to:

"primary_layers": {
                    "description": "List of IDs for materials as layer descriptions starting from the outside surface for the primary heat path",
                    "type": "array",
                    "items": {
                        "oneOf": [
                            {"type":  "string"},
                            {"$ref": "ASHRAE229.schema.json#/definitions/Material"}
                        ]
                    }
                },

I prefer to have a tight data type definition instead of open / dynamic data typing - maybe we can suggest Jason updating this part.