Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [Feature]: Extend sample gallery with filter by supported hosts #224

Open
Adam-it opened this issue Apr 17, 2024 · 1 comment
Open
Assignees
Labels
⭐ enhancement New feature or request 🤚 on hold I need to wait for something else
Milestone

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Apr 17, 2024

🎯 Aim of the feature

The aim is to provide a filtering option by supported hosts. This is kinda tricky as a single solution may have multiple SPFx components and each may have different hosts defined

📷 Images (if possible) with expected result

image

🤔 Additional remarks or comments

we could research how it is handled here
https://pnp.github.io/sp-dev-fx-webparts/samples/compatibility/

@Adam-it Adam-it added ⭐ enhancement New feature or request 🤔 research needs researching before I start hacking labels Apr 17, 2024
@Adam-it Adam-it added this to the v3.X milestone Apr 17, 2024
@Adam-it Adam-it self-assigned this Jul 28, 2024
@Adam-it
Copy link
Contributor Author

Adam-it commented Jul 29, 2024

TBH I think we may drop this. It's the same like we could show a filter option by framework. There is some but still little benefit in such a functionality and still the complexity of introducing such a filter option is quite high not to mention the problem with maintaining it.
So for now I will still leave this opened but set this to neverlog milestone and on hold to await more feedback if such a feature would be helpful

@Adam-it Adam-it modified the milestones: v3.X, neverlog Jul 29, 2024
@Adam-it Adam-it added 🤚 on hold I need to wait for something else and removed 🤔 research needs researching before I start hacking ✏️prototype labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement New feature or request 🤚 on hold I need to wait for something else
Projects
None yet
Development

No branches or pull requests

1 participant