Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Create one task for bundle & package each #386

Closed
nicodecleyre opened this issue Jan 2, 2025 · 4 comments · Fixed by #397
Closed

💡 [Feature]: Create one task for bundle & package each #386

nicodecleyre opened this issue Jan 2, 2025 · 4 comments · Fixed by #397
Assignees
@NishkalankBezawada
Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Milestone
v4.X

Comments

@nicodecleyre
Copy link
Contributor

nicodecleyre commented Jan 2, 2025 •
edited
Loading

🎯 Aim of the feature

Currently there are 2 tasks for bundle & package each. Namely:

  • Bundle (local)
  • Bundle (production)
    for the bundle task, and:
  • Package (local)
  • Package (production)

let's simplify this and create a single bundle task and a single package task. For both a prompt should first be shown asking if you want to bundle/package to your local environment or a production environment.

📷 Images (if possible) with expected result

image
image

🤔 Additional remarks or comments

No response
@nicodecleyre nicodecleyre added the ⭐ enhancement New feature or request label Jan 2, 2025
@Adam-it
Copy link
Member

Adam-it commented Jan 2, 2025

Thanks @nicodecleyre for another awesome suggestion.
I may only add that local should be the default option.
Other than that let's open it up 👍

@Adam-it Adam-it added 💪 good first issue Good for newcomers 🙏 help wanted Open for contributors labels Jan 2, 2025
@Adam-it Adam-it added this to the v4.X milestone Jan 6, 2025
@NishkalankBezawada
Copy link
Contributor

Hey @nicodecleyre & @Adam-it

Let me take this 🥇

Thanks,
Nish

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed 🙏 help wanted Open for contributors labels Jan 9, 2025
@Adam-it
Copy link
Member

Adam-it commented Jan 9, 2025

Hey @nicodecleyre & @Adam-it

Let me take this 🥇

Thanks,
Nish

Sure thing 👍
All yours 🤩

@NishkalankBezawada NishkalankBezawada mentioned this issue Jan 24, 2025
Merged
1 task
@Adam-it Adam-it linked a pull request Feb 3, 2025 that will close this issue
💡[Feature]: Create one task for bundle & package each (Fix - 386) #397
Merged
1 task
Adam-it pushed a commit that referenced this issue Feb 3, 2025
@NishkalankBezawada
Creates one task for bundle & package each. Closes: #386
cea0a3a 
## 🎯 Aim

Currently there are 2 tasks for bundle & package each. Namely:

Bundle (local)
Bundle (production)
for the bundle task, and:
Package (local)
Package (production)

With this, We achieve to create one task for bundle project. When
clicked on `Bundle project`, a prompt is shown with options `local` and
`production`. Depending on the user selection, the command is executed
in the terminal.

## 📷 Result for Bundle task

Below is for local, executing `gulp bundle`


![Untitled+video+(27)](https://github.com/user-attachments/assets/0dddd61a-8cda-4e8f-a1e6-89690c0e85c0)


Below is for production, executing `gulp bundle --ship`


![Untitled+video+(28)](https://github.com/user-attachments/assets/44081b74-37cb-4d3c-9351-0f3f7f4ac455)

## 📷 Result for Package task

Below is for both Package local and package production, executing `gulp
package-solution` & `gulp package-solution --ship`


![Untitled+video+(30)](https://github.com/user-attachments/assets/502639db-fea0-4891-aefb-4bc458f488c7)


## ✅ What was done

Added a two new methods in `TerminalCommandExecuter` with name
`bundleProject` & `packageProject`, which will execute this.

<img width="511" alt="image"
src="https://github.com/user-attachments/assets/763694f3-3783-4f52-b800-b6526da698e4"
/>


## 🔗 Related issue

> each PR should be linked with a related issue [Remove this line]

Closes: #386
@Adam-it
Copy link
Member

Adam-it commented Feb 3, 2025

I merged the PR. This should be part of a new pre-release shortly

@Adam-it Adam-it closed this as completed Feb 3, 2025
Adam-it pushed a commit that referenced this issue Feb 4, 2025
@NishkalankBezawada @Adam-it
Creates one task for bundle & package each. Closes: #386
09f50a1 
## 🎯 Aim

Currently there are 2 tasks for bundle & package each. Namely:

Bundle (local)
Bundle (production)
for the bundle task, and:
Package (local)
Package (production)

With this, We achieve to create one task for bundle project. When
clicked on `Bundle project`, a prompt is shown with options `local` and
`production`. Depending on the user selection, the command is executed
in the terminal.

## 📷 Result for Bundle task

Below is for local, executing `gulp bundle`


![Untitled+video+(27)](https://github.com/user-attachments/assets/0dddd61a-8cda-4e8f-a1e6-89690c0e85c0)


Below is for production, executing `gulp bundle --ship`


![Untitled+video+(28)](https://github.com/user-attachments/assets/44081b74-37cb-4d3c-9351-0f3f7f4ac455)

## 📷 Result for Package task

Below is for both Package local and package production, executing `gulp
package-solution` & `gulp package-solution --ship`


![Untitled+video+(30)](https://github.com/user-attachments/assets/502639db-fea0-4891-aefb-4bc458f488c7)


## ✅ What was done

Added a two new methods in `TerminalCommandExecuter` with name
`bundleProject` & `packageProject`, which will execute this.

<img width="511" alt="image"
src="https://github.com/user-attachments/assets/763694f3-3783-4f52-b800-b6526da698e4"
/>


## 🔗 Related issue

> each PR should be linked with a related issue [Remove this line]

Closes: #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NishkalankBezawada NishkalankBezawada

Labels
⭐ enhancement New feature or request 💪 good first issue Good for newcomers 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v4.X
Development

Successfully merging a pull request may close this issue.

💡[Feature]: Create one task for bundle & package each (Fix - 386) NishkalankBezawada/vscode-viva
3 participants
@nicodecleyre @NishkalankBezawada @Adam-it