Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let net_dynamic_hb success with single node network. #386

Open
RicoGit opened this issue Feb 27, 2019 · 0 comments
Open

Let net_dynamic_hb success with single node network. #386

RicoGit opened this issue Feb 27, 2019 · 0 comments

Comments

@RicoGit
Copy link
Contributor

RicoGit commented Feb 27, 2019

Problem

net_dynamic_hb test fails every time one node left in the network. With this error:
thread 'drop_and_re_add' panicked at 'crank: network queue empty', src/libcore/option.rs:1008:5

That one may be related to the test (or the test net framework) and not the production code: Of course, there are no messages in the queue if there's only one node. A single node will always immediately deliver a batch whenever we provide input.

Originally posted by @afck in #385 (comment)

Proposition

The test or test framework should handle a situation when one node left in the network.

@RicoGit RicoGit changed the title Improve test framework. Let net_dynamic_hb success with single node network. Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant