Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteratively increase max_distance in radar_dataset #63

Closed
bart1 opened this issue Mar 16, 2023 · 5 comments
Closed

Iteratively increase max_distance in radar_dataset #63

bart1 opened this issue Mar 16, 2023 · 5 comments
Labels
question Further information is requested

Comments

@bart1
Copy link
Collaborator

bart1 commented Mar 16, 2023

For reading the data it would be good to not omit points of interest when the min_neighbours is not reached. @lyashevska and me discussed that a reasonable procedure would be to increase max_distance iteratively until min_neighbours is reached. The ultimate max_distance should probably be 10 km as we have already omitted data beyond this.

@abelsiqueira
Copy link
Contributor

This is not clear to me yet. Maybe after #66 we can discuss it further.

@abelsiqueira abelsiqueira added the question Further information is requested label Mar 28, 2023
@bart1
Copy link
Collaborator Author

bart1 commented Mar 28, 2023

We discussed the way graphs were calculated. From this line

min_neighbours (int): If a point has less than this amount of neighbours, it is ignored.
I get that if annotated points are in sparse regions they are more likely to be ignored. I think that is undesirable, rather it might be good to increase the max_distance for those points so the number of neighbors might be reached

@bart1
Copy link
Collaborator Author

bart1 commented Mar 28, 2023

If it easier we can also discuss this later in person

@bart1
Copy link
Collaborator Author

bart1 commented May 11, 2023

Might also relate to #88

@abelsiqueira
Copy link
Contributor

There is no max_distance anymore, we followed a different approach.

@abelsiqueira abelsiqueira closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants