You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a good start but needs to be reworked either by the original author or by someone else interested into a full feature:
We need more information in this issue explaining the motivation & use case of the feature. My assumption that this is to allow users to send a screenshot of their friend code QR which is then used to parse their trainer name & friend code?
Once the motivation & design are clear, this should be turned into a PR against the dev branch.
If we want to support both file and URL based images, the two should be combined into one codebase that can handle both. For example, take common functionality and abstract it into a function, and then just have two different interface functions that do the url / file specific bits and call the internal function.
The function should be standalone but use our existing curl wrappers.
Config values need to be added for the API key and enabling the feature.
Documentation updates are needed to explain the feature.
If multiple individuals want to start developing this I'm happy to accept a PR for a new feature branch forked off dev to pool resources to make it happen. Once it's feature complete, open a PR to merge it to dev from where it'll become part of the next release.
Pull playername from screenshot, making use of ocr.space api
File based image
URL based image
The text was updated successfully, but these errors were encountered: