Providing a method to convert `JsDataFrame` back to `DataFrame`

[inakineitor]

I am currently working on a NodeJS and Python library that uses Polars under the hood. Currently the core of the library is written in Rust, with the bindings generated through NAPI-RS and PyO3/Maturin, respectively.

Some of the methods of the library return a Polars data frame and I am using the pyo3-polars and nodejs-polars bindings as a mean of returning it in a way that the host language will understand.

The Python implementation worked well but I am having trouble finishing the NodeJS one because the df property of the JsDataFrame struct has visibility pub(crate) instead of pub, with no method to go from JsDataFrame to DataFrame. Is there a reason for which impl Into<DataFrame> for JsDataFrame is not implemented?

If not, would you be willing to review a PR with the implemented trait?

Thank you for all the good work!

[lvvittor]

I was having a similar issue with this. Would love a PR implementing the public method. +1

[Bidek56]

@inakineitor Are you asking for these 2 methods? Thx

impl From<JsLazyFrame> for LazyFrame {
    fn from(val: JsLazyFrame) -> Self {
        val.ldf
    }
}

impl From<JsDataFrame> for DataFrame {
    fn from(val: JsDataFrame) -> Self {
        val.df
    }
}