Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different setting for each tab opening action? #5

Open
jpmhouston opened this issue Apr 24, 2020 · 3 comments
Open

Different setting for each tab opening action? #5

jpmhouston opened this issue Apr 24, 2020 · 3 comments

Comments

@jpmhouston
Copy link

You mention 3 paths to opening tabs that you customize. Why do these all have to have the same behavior?

Open new tabs at the position of the currently selected tab
** in page's context menu
** from toolbar button (in tab bar by default configuration)
** with keyboard shortcut Ctrl+Y

Why not a different setting for each? Why not different action when Option (Alt) key held down?

Note that Mac OS Safari now has different behavior for Command-T compared to the toolbar button (which always opens at the end). I'd like to replicate that.

@pollti
Copy link
Owner

pollti commented Apr 24, 2020

I'm ware of the usefulness of more settings here. However, I currently do not have the time to develop these features myself. Maybe I will at some time, I don't know.

Feel free to make pull requests :)

@pollti
Copy link
Owner

pollti commented May 27, 2020

Settings (opon left/right/disable) for the different opening options will come with the next version.

@jpmhouston
Copy link
Author

Thanks for working on this! And for adding capability to disable (remove) the tools menu item.

Nearly there. Open to the left vs. the right of the current tab might be good for some use cases (and RTL language people might like opening to the left, for example, that's good), but it's really the same feature: opening a tab here. I know that's the name of your extension :^) but I was hoping for a Right End choice on the preference popups for the toolbar button and menu item/key shortcut (and Left End i guess for completeness).

Or maybe just a single At End choice, or call it maybe Browser Default, is it easy for your extension to just let Firefox open the tab wherever it normally would.

Another idea: you control the context menu options so instead of (or in addition to?) one menu item whose behavior is controlled by your preferences, provide all the choices within the context menu: New Tab to the Left, New Tab to the Right, New Tab at the Left End, New Tab at the Right End. Maybe that's too much, but maybe just the 2 items isn't: New Tab Here and New Tab at End, and your preferences can let user pick if Here means to the right or left, and End means right end of left end (or, again, leave that up to Firefox). Something to consider if you think this will make your extension better.

Thanks for listening and spending the time to polish your extension. I've started working on one also (forked youtube-tab-playlist to scratch my own itch), and I'm seeing now how developing these can be fraught with complexity, and fighting the browser at every turn. And I looked into an extension to let me color tabs, and eventually saw that the bugzilla issue about supporting individually styled tabs has been open for 4 years with no resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants