Merge branch 'exit-messages-and-codes'

Author: warpfork

cli/errors.go

@@ -7,6 +7,7 @@ import (
 type ExitCode byte
 
 const (
+	EXIT_SUCCESS      = ExitCode(0)
 	EXIT_BADARGS      = ExitCode(1)
 	EXIT_UNKNOWNPANIC = ExitCode(2)  // same code as golang uses when the process dies naturally on an unhandled panic.
 	EXIT_USER         = ExitCode(3)  // grab bag for general user input errors (try to make a more specific code if possible/useful)

cli/run_command.go

@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"fmt"
 	"io"
 
 	"github.com/codegangsta/cli"
@@ -50,7 +51,10 @@ func RunCommandPattern(output io.Writer) cli.Command {
 			result := RunFormula(scheduler, executor, formula, ctx.App.Writer)
 			// Exit if the job failed collosally (if it just had a nonzero exit code, that's acceptable).
 			if result.Error != nil {
-				panic(Error.NewWith("job execution errored", SetExitCode(EXIT_USER)))
+				panic(Exit.NewWith(
+					fmt.Sprintf("job execution errored: %s", result.Error.Message()),
+					SetExitCode(EXIT_USER), // TODO review exit code
+				))
 			}
 
 			// Output.

cli/twerk_command.go

@@ -45,10 +45,18 @@ func TwerkCommandPattern(stdin io.Reader, stdout, stderr io.Writer) cli.Command
 			go io.Copy(stderr, job.Outputs().Reader(2))
 			result := job.Wait()
 			if result.Error != nil {
-				fmt.Fprintf(ctx.App.Writer, "error: %s\n", result.Error)
-			} else {
-				fmt.Fprintf(ctx.App.Writer, "done; exit code %d\n", result.ExitCode)
+				panic(Exit.NewWith(
+					fmt.Sprintf("job execution errored: %s", result.Error.Message()),
+					SetExitCode(EXIT_USER), // TODO review exit code
+				))
 			}
+			if result.ExitCode != 0 {
+				panic(Exit.NewWith(
+					fmt.Sprintf("done; action finished with exit status %d", result.ExitCode),
+					SetExitCode(EXIT_JOB),
+				))
+			}
+			panic(Exit.NewWith("done; action reported successful exit status", SetExitCode(EXIT_SUCCESS)))
 		},
 	}
 }