Skip to content

Skippig with overlapping segments skips to the wrong endpoint #296

@JacksonChen666

Description

@JacksonChen666

Checklist

  • I am able to reproduce the bug with the latest version.
  • I am not able to reproduce the bug with the latest version of vanilla NewPipe.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the vanilla NewPipe contribution guidelines.

Affected version

0.28.0

Steps to reproduce the bug

  1. View a video with overlapping segments (possibly in different categories), like https://www.youtube.com/watch?v=pU9sHwNKc2c (00:26 to 00:47 sponsor, with 00:30 to 00:33 preview)
  2. Skip over the sponsor segment
  3. You end up skipping to 00:33, which is not the end of the sponsor segment

Expected behavior

No response

Actual behavior

Skip to 00:47, the end of the sponsor segment

Screenshots/Recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

The general thing with segmwnts is that segments should skip cleanly without other categories. That's probably why there is overlapping segments in the first place.

SponsorBlock (extension) can skip over multiple adjacent or overlapping segments too, which Tubular doesn't seem to handle, it just skips each adjacent segment individually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions