-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Within-code docstrings? #8
Comments
Thank you for your comment. Anyway, If you want to do such kind of thing in your forked repository, you are welcome to do so (since I don't know about neuroscience well, since my major studying is genomics). |
I've added the docstrings from your readme here, and also made a couple of code changes as noted. There are a few undocumented components of the process (e.g. spine) that I couldn't figure out myself, but it seems quite well and broadly documented as is (even if you may be changing things in the future). I think the clarity was/is quite good (and that you may be underestimating your English writing skill), but in any case, if I can be of any use in the future just let me know (this is a great project/ application). Alternatively, if this sort of input / GitHub pull request isn't what you're looking for, that's perfectly fine too. |
I've noticed that the code in pycircos.py and noticed that the current version of this file doesn't include within-code doc-strings for the relevant definitions. However, the readme document features a very comprehensive and useful documentation of these (that is also PEP 8 / 257 compliant?)
Is this an intentional omission? Alternatively, would you be interested in someone transcribing these in the pertinent locations? There may well be an automated method for doing this (or an alternate version with this already done), but if not, I could produce a version with this as I work through commenting my fork of the code (attempting to make variations for neuroscience-related applications).
The text was updated successfully, but these errors were encountered: