[makefile] GNOME Shell 46 Restart Fails on X11 Systems

[dperozzi]

(1) Issue/Bug Description:
When installing Pop Shell on GNOME 46 under X11, the GNOME Shell restart mechanism fails, resulting in the "Oh no! Something has gone wrong" error screen. In one case, prematurely clicking the "Log out" button during this state led to a corrupted GNOME session that required reinstallation through TTY.

(2) Steps to reproduce (if you know):

1. Clone the repository from master_noble branch
2. Run either:

• make local-install or
• make restart-shell

3. Observe the GNOME Shell crash

(3) Expected behavior:
GNOME Shell should restart cleanly without displaying any misleading error messages which could lead the user to think that the installation didn't work.

(4) Distribution:
Ubuntu 24.04.1 LTS

(5) Gnome Shell version:
GNOME Shell 46.0

(6) Pop Shell version:

git rev-parse HEAD
104269ede04d52caf98734b199d960a3b25b88df

(7) Where was Pop Shell installed from:
Cloned from the master_noble branch and installed using '''make local-install'''.

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):
1x 4K

(9) Other Installed/Enabled Extensions:
Media controls, Top panel Workspace Scroll

(10) Other notes:

[dperozzi]

Instead of trying to restart the shell which leads to crashes in GNOME 46, we could simplify the code to just handle it with a clean logout:

# Current problematic code
if bash -c 'xprop -root &> /dev/null'; then \
    pkill -HUP gnome-shell; \
else \
    gnome-session-quit --logout; \
fi

Could be replaced with either:

gnome-session-quit --logout;

or

gnome-session-quit --logout --no-prompt;

However, then this would prevent enable to be run and should be done manually.

I'll look for better alternatives.