Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read newick format #82

Open
mufernando opened this issue Nov 12, 2020 · 4 comments
Open

read newick format #82

mufernando opened this issue Nov 12, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@mufernando
Copy link
Member

mufernando commented Nov 12, 2020

It would be cool to be able to import a Newick tree (with or without node ages) to form a base Deme object that can then be annotated with other details (split times, population sizes, etc).

Similar to msprimes feature: https://msprime.readthedocs.io/en/latest/tutorial.html#parsing-species-trees

I can definitely lend a hand if needed.

great work so far btw!!

@grahamgower
Copy link
Member

Thanks @mufernando, that seems very doable!

@jeromekelleher
Copy link
Member

Good idea. One downside though is that we start adding dependencies. We're using the newick package in msprime which is pretty lightweight, but it doesn't support extended newick, which would ultimately be needed to do this properly.

Still, it seems worth it, and we can mostly just copy the code from msprime I think.

@grahamgower
Copy link
Member

For any GPL code we want to copy from msprime, we'll have to explicitly contact the original authors to check they're happy to have their code modified and more permissively licensed for inclusion in demes.

$ git blame species_trees.py -c | cut -f2 | sed 's/(//' | sort -u
Ben Jeffery
Jerome Kelleher
Michael Matschiner

@jeromekelleher
Copy link
Member

I'm confident that we can get this approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants