Missing JVM on Windows after Maven build

[JGKle]

Describe the bug
When I build with Maven on Linux, the Win32 build it produces reports "Incompatible JVM" on launch. By diffing it against an official release downloaded from github, I found that it's missing plugins/name.abuchen.zulu.jre.win32.x86_64_21.0.5 (and the reference to it in PortfolioPerformance.ini). If I manually copy that plugin from an official release & edit the .ini file, it works.

Is @buchen using a different build process? (see steps below)

To Reproduce
Steps to reproduce the behavior:

1. On Linux: ../apache-maven-3.9.11/bin/mvn -f portfolio-app/pom.xml -Dmaven.repo.local=../m2 clean verify
2. Grab the Win32 release from portfolio-product/target/products
3. Copy to a Windows PC
4. Launch. You will see the error dialog shown below (screenshot)
5. Edit PortfolioPerformance.ini & add -vm plugins/name.abuchen.zulu.jre.win32.x86_64_21.0.5/jre/bin
6. Copy the plugins/name.abuchen.zulu.jre.win32.x86_64_21.0.5/jre/bin folder from a Windows release downloaded from github
7. Now it works

Expected behavior

Windows build works without having to manually edit PortfolioPerformance.ini & copy the runtime from a prior installation

Screenshots

[Morpheus1w3]

Try mvn clean verify -Dtycho.disableP2Mirrors -Ppackage-distro.

[JGKle]

Thanks - yup, looks like that was it! Should probably be fixed in the docs, which show a command that results in a broken/unrunnable build on Windows: https://github.com/portfolio-performance/portfolio/blob/master/CONTRIBUTING.md#build-with-maven