Skip to content

Add 2024_Sasso_PNAS #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 24, 2025
Merged

Add 2024_Sasso_PNAS #41

merged 10 commits into from
Feb 24, 2025

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Jan 7, 2025

Adds/Updates 2024_Sasso_PNAS

Linked to poseidon-framework/minotaur-recipes#42

New packages added to the minotaur archive are always published in version 1.0.0. This means that nay and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • The package description has been updated to the title of the paper.
  • This package contains a BibTex file.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields (if applicable).
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
    • The BibTex key used for the citation is identical to that in the corresponding package in the community archive.
    • The DOI in the BibTex file is identical to the one used in the corresponding package in the comunity archive.
  • If the janno information was collected manually:
    • Add any additional contributors to POSEIDON.yml
  • Any scripts/commands used to prepare the pacakge are kept track of in the README file.
  • Country information is also present in the Country_ISO column.
  • Any columns in the janno that are entirely missing or n/a should be removed from the janno.

Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersion Major --checksumAll

@TCLamnidis TCLamnidis added the help wanted Extra attention is needed label Jan 7, 2025
@TCLamnidis TCLamnidis marked this pull request as ready for review January 7, 2025 14:59
@stschiff stschiff marked this pull request as draft February 11, 2025 09:35
Kavlahkaff and others added 4 commits February 18, 2025 16:49
* filled janno for 2024_Sasso_PNAS

* added group names

* added contextual dates, fixed quotation marks

* Add calibrated dates for C14 samples. Add extra publication for samples with C14 taken from other paper.

---------

Co-authored-by: Thiseas C. Lamnidis <[email protected]>
@TCLamnidis TCLamnidis requested a review from nevrome February 18, 2025 16:01
@TCLamnidis TCLamnidis marked this pull request as ready for review February 18, 2025 16:02
@TCLamnidis TCLamnidis added Final review needed This PR needs its final review before going live and removed help wanted Extra attention is needed labels Feb 18, 2025
@TCLamnidis TCLamnidis assigned TCLamnidis and unassigned Kavlahkaff Feb 18, 2025
@TCLamnidis TCLamnidis merged commit 3da8ff5 into main Feb 24, 2025
1 check passed
@TCLamnidis TCLamnidis deleted the 2024_Sasso_PNAS branch February 24, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final review needed This PR needs its final review before going live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants