Skip to content

Add: 2022_Gretzinger_AngloSaxons #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 24, 2025
Merged

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Feb 19, 2025

Adds2022_Gretzinger_AngloSaxons

Linked to poseidon-framework/minotaur-recipes#35

If this PR adds a new package to the archive, please note:
New packages added to the minotaur archive are always published in version 1.0.0.
This means that any and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • The package description has been updated to the title of the paper.
  • This package contains a BibTex file.
  • The month field in the BibTex file is formatted as a three letter code.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields (if applicable).
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
    • The BibTex key used for the citation is identical to that in the corresponding package in the community archive.
    • The DOI in the BibTex file is identical to the one used in the corresponding package in the community archive.
  • If the janno information was collected manually:
    • Add any additional contributors to POSEIDON.yml
  • Any scripts/commands used to prepare the pacakge are kept track of in the README file.
  • Country information is also present in the Country_ISO column.
  • Any columns in the janno that are entirely missing or n/a should be removed from the janno.
  • Poseidon_IDs in the Relation_To column contain the _MNT suffix.

Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersion Major --checksumAll

@TCLamnidis
Copy link
Member Author

The bibTex key here is different from the one on the community archive (GretzingerNature2022 instead of Gretzinger2022) but the community archive one does not follow the Poseidon specification (see context-information section)

@TCLamnidis TCLamnidis requested a review from stschiff February 19, 2025 17:15
@TCLamnidis TCLamnidis added the Final review needed This PR needs its final review before going live label Feb 19, 2025
@TCLamnidis TCLamnidis self-assigned this Feb 20, 2025
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great. Thanks. Just one comment:

  1. In the Relation_To column you currently have non-existent Poseidon_IDs. For example ADN003_MNT doesn't exist, but ADN003_ss_MNT does, so this needs correction.

@TCLamnidis
Copy link
Member Author

Done!

@TCLamnidis TCLamnidis merged commit ef96c41 into main Feb 24, 2025
1 check passed
@TCLamnidis TCLamnidis deleted the 2022_Gretzinger_AngloSaxons branch February 24, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final review needed This PR needs its final review before going live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants