Skip to content

Commit 356f40b

Browse files
authored
E2E Test: try to catch Interrupt text but don't require it (#8144)
Allow catch of interrupt text to fail when running all cells ### QA Notes @:notebooks
1 parent 1d119ca commit 356f40b

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

test/e2e/pages/notebooks.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,10 @@ export class Notebooks {
144144
await test.step('Run all cells', async () => {
145145
await this.code.driver.page.getByLabel('Run All').click();
146146
const stopExecutionLocator = this.code.driver.page.locator('a').filter({ hasText: /Stop Execution|Interrupt/ });
147-
await expect(stopExecutionLocator).toBeVisible();
148-
await expect(stopExecutionLocator).not.toBeVisible({ timeout: timeout });
147+
try {
148+
await expect(stopExecutionLocator).toBeVisible();
149+
await expect(stopExecutionLocator).not.toBeVisible({ timeout: timeout });
150+
} catch { } // can be normal with very fast execution
149151
});
150152
}
151153

test/e2e/tests/notebook/notebook-large-python.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test.use({
1111
});
1212

1313
// test is too heavy for web
14-
test.describe.skip('Large Python Notebook', {
14+
test.describe('Large Python Notebook', {
1515
tag: [tags.NOTEBOOKS, tags.WIN]
1616
}, () => {
1717

test/e2e/tests/plots/matplotlib-interact.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ test.use({
1111
suiteId: __filename
1212
});
1313

14-
test.describe.skip('Matplotlib Interact', { tag: [tags.PLOTS, tags.NOTEBOOKS] }, () => {
14+
test.describe('Matplotlib Interact', { tag: [tags.PLOTS, tags.NOTEBOOKS] }, () => {
1515

1616
test('Python - Matplotlib Interact Test', {
1717
tag: [tags.CRITICAL, tags.WEB, tags.WIN],

0 commit comments

Comments
 (0)