-
Notifications
You must be signed in to change notification settings - Fork 108
Enable reticulate by default #8564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
fdd067d
to
d57094a
Compare
d57094a
to
0d440a7
Compare
I may have wrongly affirmed that this was the case, but looking at the code now we do actually check if an R interpreter is available (so we don't show reticulate for Python only users), but not if the reticulate package is installed. positron/extensions/positron-reticulate/src/extension.ts Lines 73 to 79 in 0d440a7
The reasoning for this is that we don't actually know which R interpreter is going to be used until the session is actually being created. For instance, at registration time (when the extension is loaded), there might be no R interpreter really running, and we probably do not want to start one for that. We may be able to listen to 'session created' events and only We do check if reticulate is installed when creating the reticulate session though, and if not, we offer for installation: positron/extensions/positron-reticulate/src/extension.ts Lines 434 to 456 in 0d440a7
What do you think? |
Ah, I see what you mean about possible multiple R interpreters. 🤔 I checked with a few folks and we do think this is getting featured too prominently now, though, for too many users for whom this isn't relevant. Also, if someone is only an R user, then it starts to look like reticulate is the only Python you can see in Positron (not what we're going for). Two possible options moving forward could be:
|
Ok! I understand the point of making it too prominent for many users which may not be interested in starting positron this way.
We can't really check without starting a interpreter, which we probably don't want to do just for checking. A small variation of that is registering the reticulate session manager only if there's a running R session and reticulate is installed on it. Although, this might not play well with restoring sessions (the reticulate session could be lost if at session restoration the reticulate manager is not registered).
I'm OK with keeping it this way. Maybe reticulate (the R package) can advertise this feature more pominetly when loaded within Positron trough startup messages. Possibly even emitting a clickable link to toggle the option.
Maybe when no Python interpreters are found that modal should include a 'Install Python' option that just installs Python the way we really want to recommend people to. The reticulate feature, IMO, is a very conventient way for R users with no experience with Python to get access to a Python interpreter without having to learn environment management, etc. |
This could be a good option, if you are up for exploring it:
This also seems like a good option to me:
You can create the links like |
Addresses #8563
Full test suite passing: https://github.com/posit-dev/positron/actions/runs/16452982927
Added some docs in posit-dev/positron-website#123
Release Notes
New Features
Bug Fixes
QA Notes
@:reticulate