docs(bookmark): Remove unnecessary reactive.isolate (#2129)

Author: schloerke

shiny/api-examples/bookmark_callbacks/app.py

@@ -57,8 +57,7 @@ async def _():
     @session.bookmark.on_bookmark
     async def _(state: BookmarkState):
         print("Bookmark state:", state.input, state.values, state.dir)
-        with reactive.isolate():
-            state.values["lowercase"] = lowercase_letter()
+        state.values["lowercase"] = lowercase_letter()
 
     # After saving state, we will update the query string with the bookmark URL.
     @session.bookmark.on_bookmarked

shiny/bookmark/README.md

@@ -325,8 +325,7 @@ def server(input: Inputs, output: Outputs, session: Session):
     # Store custom values before bookmarking
     @session.bookmark.on_bookmark
     async def _(state: BookmarkState):
-        with reactive.isolate():
-            state.values["lowercase"] = lowercase_letter()
+        state.values["lowercase"] = lowercase_letter()
 
     # Update URL after bookmarking
     @session.bookmark.on_bookmarked

shiny/plotutils.py

@@ -310,7 +310,7 @@ def near_points(
     if all_rows:
         # Add selected_ column if needed
         new_df["selected_"] = False
-        new_df.iloc[  # pyright: ignore[reportArgumentType]
+        new_df.iloc[  # pyright: ignore[reportArgumentType,reportCallIssue]
             keep_idx,
             new_df.columns.get_loc(  # pyright: ignore[reportUnknownMemberType]
                 "selected_"

tests/playwright/shiny/components/data_frame/edit/app.py

@@ -44,7 +44,7 @@
 df.loc[:, "Sample Number"] = df.loc[
     :, "Sample Number"
 ].apply(  # pyright: ignore[reportCallIssue]
-    lambda x: ui.HTML(  # pyright: ignore[reportUnknownLambdaType]
+    lambda x: ui.HTML(  # pyright: ignore[reportUnknownLambdaType,reportUnknownArgumentType]
         str(
             ui.tags.strong(
                 ui.tags.em(str(x))  # pyright: ignore[reportUnknownArgumentType]

tests/playwright/shiny/components/data_frame/html_columns/app.py

@@ -50,7 +50,7 @@ def random_generator():
 pd_penguins["Island"] = pd_penguins[
     "Island"
 ].apply(  # pyright: ignore[reportUnknownMemberType]
-    lambda z: ui.TagList(  # pyright: ignore[reportUnknownLambdaType]
+    lambda z: ui.TagList(  # pyright: ignore[reportUnknownLambdaType,reportUnknownArgumentType]
         ui.input_checkbox(f"checkbox_{z}_{random_generator()}", f"{z}"),
         ui.tags.img(
             src="https://dka575ofm4ao0.cloudfront.net/pages-transactional_logos/retina/276517/posit-logo-fullcolor-TM.png",
@@ -62,10 +62,10 @@ def random_generator():
 # Set the first value of the column to an html object.
 # Narwhals does not inspect the types beyond the first row.
 # Theforefore, we should not either and need to set the type to object.
-pd_penguins.iloc[0, 5] = ui.div(  # pyright: ignore[reportArgumentType]
+pd_penguins.iloc[0, 5] = ui.div(  # pyright: ignore[reportArgumentType,reportCallIssue]
     pd_penguins.iloc[0, 5]  # pyright: ignore[reportArgumentType]
 )
-pd_penguins.iloc[1, 5] = ui.p(  # pyright: ignore[reportArgumentType]
+pd_penguins.iloc[1, 5] = ui.p(  # pyright: ignore[reportArgumentType,reportCallIssue]
     ui.input_action_button("pandas_test_cell_button", "Test button"),
     ui.output_text_verbatim("pandas_test_cell_text", placeholder=True),
 )