You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the @spec for the authorize_url/2 function in the Assent library is incorrect and does not match its actual return values. Specifically, the spec does not account for the {:error, term()} case, which causes issues with Dialyzer.
Thanks! I realized this is something that was not tested at all in the test suite, so I updated the integration server in #166 to ensure we get any typespec errors for integrations moving forward!
I noticed that the
@spec
for theauthorize_url/2
function in the Assent library is incorrect and does not match its actual return values. Specifically, the spec does not account for the{:error, term()}
case, which causes issues with Dialyzer.Current @SPEC
Actual Behavior
According to the implementation, the function can return either:
{:ok, %{session_params: %{state: binary()}, url: binary()}}
{:error, term()}
The
@spec
should reflect this, but currently, it only defines the{:ok, ...}
case.Steps to Reproduce
authorize_url/2
function in a project with Dialyzer enabled.{:error, _}
in the function's return value.{:error, _}
can never match.The text was updated successfully, but these errors were encountered: