[RANGR-975] Remove AppCenter and update Runway comment with NitroAppPortal link (#523)

Task on Runway
[RANGR-975](https://nitro.powerhrg.com/runway/backlog_items/RANGR-975).

Author: AlexandreHauber

Gemfile

@@ -3,7 +3,7 @@ source "https://rubygems.org"
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 gem "fastlane", "~> 2.227.0"
-gem "json", "~> 2.10.1"
+gem "json", "~> 2.10.2"
 gem 'httparty'
 
 # Until Fastlane includes them directly.

Gemfile.lock

@@ -11,7 +11,7 @@ GEM
     artifactory (3.0.17)
     atomos (0.1.3)
     aws-eventstream (1.3.2)
-    aws-partitions (1.1066.0)
+    aws-partitions (1.1070.0)
     aws-sdk-core (3.220.1)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.992.0)
@@ -35,7 +35,7 @@ GEM
     colored2 (3.1.2)
     commander (4.6.0)
       highline (~> 2.0.0)
-    csv (3.3.2)
+    csv (3.3.3)
     declarative (0.0.20)
     digest-crc (0.7.0)
       rake (>= 12.0.0, < 14.0.0)
@@ -114,8 +114,6 @@ GEM
       xcodeproj (>= 1.13.0, < 2.0.0)
       xcpretty (~> 0.4.0)
       xcpretty-travis-formatter (>= 0.0.3, < 2.0.0)
-    fastlane-plugin-appcenter (2.1.3)
-      csv
     fastlane-sirp (1.0.0)
       sysrandom (~> 1.0)
     gh_inspector (1.1.3)
@@ -233,10 +231,9 @@ PLATFORMS
 DEPENDENCIES
   abbrev
   fastlane (~> 2.227.0)
-  fastlane-plugin-appcenter
   httparty
-  json (~> 2.10.1)
+  json (~> 2.10.2)
   mutex_m
 
 BUNDLED WITH
-   2.6.2
+   2.6.6

Jenkinsfile

@@ -21,10 +21,6 @@ secrets = [
     credentialsId: 'nitro-runway-api-token-tps-40',
     variable: 'RUNWAY_API_TOKEN'
   ],
-  appcenter: [
-    credentialsId: 'appcenter-token',
-    variable: 'APPCENTER_API_TOKEN'
-  ],
   nitro_mdm: [
     credentialsId: 'a5876938-2cc6-4921-9aaa-12f224fe60fe', 
     variable: 'NITRO_MDM_API_KEY'
@@ -138,7 +134,6 @@ def setupEnv(block) {
   withCredentials([
     string(secrets.github),
     string(secrets.runway),
-    string(secrets.appcenter),
     string(secrets.nitro_mdm),
     string(secrets.fastlane_app_pass)
   ]) {
@@ -263,7 +258,7 @@ def uploadiOS() {
   def version = sh(script: "xcodebuild -project 'PlaybookShowcase/PlaybookShowcase.xcodeproj' -target 'PlaybookShowcase-iOS' " +
     "-showBuildSettings | grep MARKETING_VERSION | sed 's/.*= //'", returnStdout: true).trim()
 
-  fastlane("upload_ios suffix:${buildSuffix()} type:${buildType()} release_notes:\"${trimmedReleaseNotes}\" appcenter_token:${APPCENTER_API_TOKEN} " +
+  fastlane("upload_ios suffix:${buildSuffix()} type:${buildType()} release_notes:\"${trimmedReleaseNotes}\" " +
     "nitro_mdm_api_token:${NITRO_MDM_API_KEY} build_number:${buildNum} version:${version} pr_number:\"${pullRequestID}\"")
 }
 
@@ -274,7 +269,7 @@ def uploadmacOS() {
   def version = sh(script: "xcodebuild -project 'PlaybookShowcase/PlaybookShowcase.xcodeproj' -target 'PlaybookShowcase-macOS' " +
     "-showBuildSettings | grep MARKETING_VERSION | sed 's/.*= //'", returnStdout: true).trim()
 
-  fastlane("upload_macos suffix:${buildSuffix()} type:${buildType()} release_notes:\"${trimmedReleaseNotes}\" appcenter_token:${APPCENTER_API_TOKEN} " +
+  fastlane("upload_macos suffix:${buildSuffix()} type:${buildType()} release_notes:\"${trimmedReleaseNotes}\" " +
     "nitro_mdm_api_token:${NITRO_MDM_API_KEY} build_number:${buildNum} version:${version} pr_number:\"${pullRequestID}\"")
 }
 

fastlane/Fastfile

@@ -15,14 +15,11 @@
 
 require 'httparty'
 
-zip_file = ''
-
 default_platform(:ios)
 
 build_path = "BuildTemp/Archives"
 derived_data_path = "DerivedData"
 ios_plist = "./Info.plist"
-appcenter_token = "bf0ae509c985f2a1102c2ad53894b35a5fa5383e"
 project = './PlaybookShowcase/PlaybookShowcase.xcodeproj'
 
 def target_ios(suffix = nil)
@@ -106,35 +103,11 @@ end
 desc "Upload iOS build"
 lane :upload_ios do |opts|
   keep_trying {
-    ship_ios_to_appcenter(opts)
     opts[:platform] = "ios"
     distribute_to_mdm(opts)
   }
 end
 
-desc "Ship iOS to App Center"
-lane :ship_ios_to_appcenter do |opts|
-
-  app_name = "Playbook-Showcase-Beta"
-  if opts[:type] == 'production'
-    app_name = "Playbook-Showcase"
-  end
-
-  opts[:os] = 'ios'
-  appcenter_upload(
-    api_token: appcenter_token,
-    owner_name: "powerhome",
-    owner_type: "organization",
-    app_name: app_name,
-    file: "#{target_ios(opts[:suffix])}.ipa",
-    version: "#{opts[:build_number]}",
-    release_notes: "#{opts[:release_notes]}",
-    destinations: "Rebels",
-    destination_type: "group",
-    upload_build_only: false
-  )
-end
-
 desc "Export App Pass to Environment"
 lane :export_app_pass do |opts|
   # Add app-specific-password to environment variable
@@ -156,40 +129,11 @@ end
 desc "Upload macOS build"
 lane :upload_macos do |opts|
   keep_trying {
-    ship_macos_to_appcenter(opts)
     opts[:platform] = "macos"
     distribute_to_mdm(opts)
   }
 end
 
-desc "Ship macOS to App Center"
-lane :ship_macos_to_appcenter do |opts|
-
-  app_name = "Playbook-Swift-Mac-Beta"
-  if opts[:type] == 'production'
-    app_name = "Playbook-Swift-Mac"
-  end
-
-  #compress file
-  zip_file = "#{target_macos(opts[:suffix])}.zip"
-  sh "ditto -c -k --sequesterRsrc --keepParent '../#{target_macos(opts[:suffix])}.app' '../#{zip_file}'"
-
-  opts[:os] = 'macos'
-  appcenter_upload(
-    api_token: appcenter_token,
-    owner_name: "powerhome",
-    owner_type: "organization",
-    app_name: app_name,
-    app_os: "macOS",
-    file: zip_file,
-    version: "#{opts[:build_number]}",
-    release_notes: "#{opts[:release_notes]}",
-    destinations: "Rebels",
-    destination_type: "group",
-    upload_build_only: false
-  )
-end
-
 desc "Upload to Nitro MDM"
 lane :distribute_to_mdm do |opts|
 
@@ -212,7 +156,7 @@ lane :distribute_to_mdm do |opts|
 
   file_path = "../#{target_ios(opts[:suffix])}.ipa"
   if platform == "macos"
-    file_path = "../#{zip_file}"
+    file_path = "../#{target_macos(opts[:suffix])}.app.zip"
   end
   output_file = "../upload-build-to-nitro-details.json"
 
@@ -251,34 +195,21 @@ lane :create_runway_comment do |opts|
   build_number = opts[:build_number]
   release_notes = "#{opts[:release_notes]}"
 
-  ios_app_name = "Playbook-Showcase-Beta"
-  if type == 'production'
-    app_name = "Playbook-Showcase"
-  end
-
-  macos_app_name = "Playbook-Swift-Mac-Beta"
+  app_id = "com.powerhrg.PlaybookShowcase.dev"
   if type == 'production'
-    app_name = "Playbook-Swift-Mac"
+    app_name = "com.powerhrg.PlaybookShowcase"
   end
 
   merged_comment = ''
   if type == 'production'
     merged_comment = "✅ MERGED ✅\n\n"
   end
 
-  # https://install.appcenter.ms/orgs/powerhome/apps/#{app_name}/releases/#{release_num}
-  # Generate the link above based on this call:
-  version_info = appcenter_fetch_version_number(
-    api_token: appcenter_token,
-    owner_name: "powerhome",
-    app_name: ios_app_name
-  )
-
   comment = <<~HEREDOC
   <p><b>#{merged_comment}#{type} build #{build_number}</b></p>
   <ul>
-    <li>PlaybookShowcase-iOS: <a href=#{"https://install.appcenter.ms/orgs/powerhome/apps/#{ios_app_name}/releases/#{version_info["id"]}"}>iOS</a></li>
-    <li>PlaybookShowcase-macOS: <a href=#{"https://install.appcenter.ms/orgs/powerhome/apps/#{macos_app_name}/releases/#{version_info["id"]}"}>macOS</a></li>
+    <li>PlaybookShowcase-iOS: <a href=#{"https://nitro.powerhrg.com/mdm/app_builds/#{app_id}/iOS"}>iOS Build #{build_number}</a></li>
+    <li>PlaybookShowcase-macOS: <a href=#{"https://nitro.powerhrg.com/mdm/app_builds/#{app_id}/macOS"}>macOS Build #{build_number}</a></li>
   </ul>
   HEREDOC