Lazer multiplayer room pages need to show full room history

[Walavouchey]

lazer lobbies, e.g. https://osu.ppy.sh/multiplayer/rooms/399751, do not show results on individual beatmaps, unlike stable lobbies e.g. https://osu.ppy.sh/community/matches/108242105

this is important for tournaments because these match result pages are saved for later auditing, which is a requirement for getting badged

found while archiving match results for ppy/osu-wiki#9875

[nanaya]

This may be problematic after moving multiplayer scores to solo score table since the values could change when there's scoring update. @peppy

Apparently it shouldn't change. All that's needed would be to migrate existing multiplayer scores to solo scores table with correct mapping entries.

[bdach]

Bumping because this was requested for the purposes of running further tournaments on lazer.

As far as I can tell there are a few potential disparate ways forward here:

• Have the "new" multiplayer pages (/multiplayer/rooms/{id}) show history information in some new way that isn't there in place right now. This is a rather open avenue, you could do many things here, so I'm not even entirely sure where to start with that.
• Do something to reuse the "old" multiplayer pages (community/matches/{id}) such that they can work with lazer multiplayer rooms. I see two subpaths here:
  • Doing some magic web-side to transmogrify the data that we have into the shape that that page / endpoint expects
  • Having osu-server-spectator insert rows in osu_mp database to simulate operation of stable and thus create a match page automagically.

Things to note:

• Right now, for lazer mp rooms, out of all things on that match history page, we only really have scores in the database. We don't have user history (joins/leaves), we don't have host changes, we don't have kicks. I'm unsure of how much this matters and how much the tournament people rely on it (will probably ask around).
• One thing that popped to my mind is that this match history page is supposed to be "archival" in nature, i.e. it should be immutable. Which makes me partial to the "manually insert rows in osu_mp" approach, because that way, we can do stuff on the scores tables and it won't accidentally break archived match logs on wiki pages or whatever.

Open questions:

• Do we want this history scored for every single multiplayer room ever, or do we want to limit it to specific rooms?

Interested in opinions from all potential stakeholders (@peppy @smoogipoo @ppy/team-web)

[peppy]

Do we want this history scored for every single multiplayer room ever, or do we want to limit it to specific rooms?

For the legacy tables, we keep history around for n months, and have a persist flag for tournament matches specifically.

Having osu-server-spectator insert rows in osu_mp database to simulate operation of stable and thus create a match page automagically.

This is the only one I'd quite strongly against (for jank factor).

We don't have user history (joins/leaves), we don't have host changes, we don't have kicks. I'm unsure of how much this matters and how much the tournament people rely on it (will probably ask around).

I'd like to see this return because it adds some flavour to the history of the room. It would also be nice to somehow show chat inline if we could, for instance.

[bdach]

This is the only one I'd quite strongly against (for jank factor).

That's fine, but has further implications:

• I guess we'd need new tables for the match events and such? They'd need a schema designed (but probably one that closely mirrors the old?)
• Do we try to unify / back-migrate the old multiplayer rooms to the new structure like with scores, or do we have 2 table schemas and just accept them co-existing?
• As mentioned above, the expectation is probably such that stuff like total score should be "frozen in time" for archival purposes, which probably means that we need to copy some of that stuff out so that we don't end up accidentally rewriting history when doing a mod multiplier rebalance N months down the line?

I'd like to see this return because it adds some flavour to the history of the room. It would also be nice to somehow show chat inline if we could, for instance.

Tournament committee seems to agree with this, and asked for even more data that stable apparently doesn't provide (like match aborts to be logged), so there's that.

[bdach]

I'm gonna start playing around with trying to implement this with the following constraints:

• Will use multiplayer_rooms, multiplayer_playlist_items et al., with potentially one new extra table for loose events (like join / leave / kick / whatever)
• Will try reusing the existing match page layout (as in https://osu.ppy.sh/community/matches/108242105) for realtime multiplayer rooms specifically by somehow smushing the old view with the new tables (probably via something resembling score transformers and such)
• The old playlists page (like https://osu.ppy.sh/multiplayer/rooms/399751) will stay for playlists specifically

I guess if anyone sees something flagrantly wrong with those assumptions then I'd appreciate being told sooner than later.

[peppy]

Sure I can get behind that. Seems like the fastest path to getting-things-working.

[nanaya]

Will try reusing the existing match page layout (as in https://osu.ppy.sh/community/matches/108242105) for realtime multiplayer rooms specifically by somehow smushing the old view with the new tables (probably via something resembling score transformers and such)

I imagine this would also be useful for playlists (viewing result of individual playlist items)

[bdach]

I imagine this would also be useful for playlists (viewing result of individual playlist items)

Not being able to see individual playlist item results is a valid point but I don't think reusing the match page verbatim would work well there. As in, in playlists you have the aggregate score over all playlist items which is the "win condition" of the playlist I guess, so I'd probably see it having a bit of a different layout maybe. Dunno.

Realtime multiplayer fits way better into the /community/matches page layout as written without further adjustments than playlists do to me.