Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team ranking tab should always be visible on beatmap info page #12035

Open
Joehuu opened this issue Mar 21, 2025 · 1 comment
Open

Team ranking tab should always be visible on beatmap info page #12035

Joehuu opened this issue Mar 21, 2025 · 1 comment

Comments

@Joehuu
Copy link
Member

Joehuu commented Mar 21, 2025

Noticed when trying to fix ppy/osu#32508.

There is an inconsistency with client and web right now. The client implementation in ppy/osu#32360 always shows the tab while the web implementation in #11989 hides it when not in a team. Leaning towards always showing, so users who are not in a team know that teams exist and that this feature is a thing within teams.

Edit: didn't know it was pointed out during review in client: ppy/osu#32360 (comment), but I would want the inconsistency resolved before fixing the above issue.

@Joehuu Joehuu changed the title Team ranking should always be visible on beatmap info page Team ranking tab should always be visible on beatmap info page Mar 21, 2025
@peppy
Copy link
Member

peppy commented Mar 25, 2025

Dunno. Personally think it's fine being inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants