Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev vs. Prod workflow #8

Open
JohnCoene opened this issue Sep 3, 2021 · 2 comments
Open

Dev vs. Prod workflow #8

JohnCoene opened this issue Sep 3, 2021 · 2 comments

Comments

@JohnCoene
Copy link
Member

This would definitely require dev and prod builds but I feel it could be handled better.
Having to switch manually I know I'm personally bound to make mistakes myself.

This issue may be somewhat relevant.
I raised this issue for packer which is similar to this project but
for JavaScript in a sense.

If we have dev and prod I think we need a way to ensure users do not publish to CRAN or push to github
dev code. My idea with the issue above was not with document but with devtools::check.

Current alternative in packer Github pre-commit hook to check that output files are bundled, similar
can be done here but still does not protect from pushing dev to CRAN.

@krlmlr
Copy link
Member

krlmlr commented Oct 16, 2021

We can make the dev mode add something that would fail R CMD check but otherwise not affect the functionality of the code.

I double-checked clean and smudge filters, they might work for inline preprocessing but we wanted to move away from that in the longer run.

@moodymudskipper
Copy link
Member

moodymudskipper commented Oct 25, 2021

We might have a Q folder inside of the R folder, the structure is legal and files in the Q folder are ignored when building the package.

The R files would be locked so user doesn't mess up with them, rpp_to_dev() (or a newly named function) would synchronise the R files with the Q files (which might have extension .q).

rpp::load_all() would load the "Q" folder rather than the "R" folder

This also ensures the tests are always run with the dev code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants