You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi guys, great library, it definitely saved me some time! 👍🏻
I encountered one issue while implementing it to the large mono-repo app: the validateDependencies method does not respect dependencies inheritance. So, if our application has the following structure:
and both someService and someOtherService inherit the dependencies from the root's package.json. It will exit with process.exit(-1) and display [preact] Missing/incorrect dependencies.. That is because neither of these packages has preact, next-plugin-preact, or any required library in the package.json - it is inherited from the root.
What's troubling me is the result of process.cwd(). It points to packages/someService/, but we run the start command from the root level, so it might be a bad lerna configuration 🤔 .
Anyhow, I managed to fix this by replacing join(process.cwd(), 'package.json') with join(__dirname, '..', '..', 'package.json');
Hi guys, great library, it definitely saved me some time! 👍🏻
I encountered one issue while implementing it to the large mono-repo app: the
validateDependencies
method does not respect dependencies inheritance. So, if our application has the following structure:and both
someService
andsomeOtherService
inherit the dependencies from the root's package.json. It will exit withprocess.exit(-1)
and display[preact] Missing/incorrect dependencies.
. That is because neither of these packages has preact, next-plugin-preact, or any required library in the package.json - it is inherited from the root.What's troubling me is the result of
process.cwd()
. It points topackages/someService/
, but we run the start command from the root level, so it might be a bad lerna configuration 🤔 .Anyhow, I managed to fix this by replacing
join(process.cwd(), 'package.json')
withjoin(__dirname, '..', '..', 'package.json');
next-plugin-preact/packages/next-plugin-preact/index.js
Line 123 in 9dd2bc8
The text was updated successfully, but these errors were encountered: