Merge pull request #468 from preactjs/plugin-order-2

marvinhagemeister · web-flow · commit 17bf635031e7 · 2021-03-27T22:34:10.000+01:00
Fix wrong plugin ordering
diff --git a/.changeset/violet-grapes-sparkle.md b/.changeset/violet-grapes-sparkle.md
@@ -0,0 +1,5 @@
+---
+'wmr': patch
+---
+
+Fix incorrect plugin ordering introduced in #465 (unreleased)
diff --git a/packages/wmr/src/bundler.js b/packages/wmr/src/bundler.js
@@ -88,7 +88,7 @@ export async function bundleProd({
 	});
 
 	// Plugins are pre-sorted
-	const split = plugins.findIndex(p => p.enforce !== 'post');
+	const split = plugins.findIndex(p => p.enforce === 'post');
 
 	const bundle = await rollup.rollup({
 		input,
diff --git a/packages/wmr/src/wmr-middleware.js b/packages/wmr/src/wmr-middleware.js
@@ -66,7 +66,7 @@ export default function wmrMiddleware({
 	root = root || cwd;
 
 	// Plugins are pre-sorted
-	const split = plugins.findIndex(p => p.enforce !== 'post');
+	const split = plugins.findIndex(p => p.enforce === 'post');
 	const NonRollup = createPluginContainer(
 		[
 			...plugins.slice(0, split),

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'wmr': patch
 +---
++
 +Fix incorrect plugin ordering introduced in #465 (unreleased)
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export default function wmrMiddleware({`
`66`	`66`	`root = root \|\| cwd;`
`67`	`67`
`68`	`68`	`// Plugins are pre-sorted`
`69`		`- const split = plugins.findIndex(p => p.enforce !== 'post');`
	`69`	`+ const split = plugins.findIndex(p => p.enforce === 'post');`
`70`	`70`	`const NonRollup = createPluginContainer(`
`71`	`71`	`[`
`72`	`72`	`...plugins.slice(0, split),`