-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested
Description
The adapter would benefit from a configuration file as right now quantities like the coupling mesh name, coupling data names, participant name, etc. For example, a configuration file like
{
"participant_name": "Neumann",
"config_file_name": "../precice-config.xml",
"interface": {
"coupling_mesh_name": "Neumann-Mesh",
"write_data_name": "Temperature",
"read_data_name": "Heat-Flux"
}
}can be added. The format can either be JSON or YAML (more about format choices in precice/preeco-orga#32). Currently the data and mesh names are hard-coded in the DuMuX simulation code, and passed to the adapter functions in each call. This is inefficient and error prone. With a configuration file the names will be defined at one single place. If data is read or written from the adapter, it would need an identifier to associate it to a particular name inside the adapter.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededquestionFurther information is requestedFurther information is requested