Skip to content

test: enable windows doc tests #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Hofer-Julian
Copy link
Contributor

We disabled doc tests on Windows early on, since Windows support wasn't really there then.

We for sure want to test this now.

We disabled doc tests on Windows early on, since Windows support wasn't really there then.

We for sure want to test this now.
@Hofer-Julian Hofer-Julian requested a review from baszalmstra June 5, 2025 09:37
@Hofer-Julian Hofer-Julian added test:extra_slow Run the extra slow tests and removed test:extra_slow Run the extra slow tests labels Jun 5, 2025
@baszalmstra
Copy link
Contributor

baszalmstra commented Jun 10, 2025

The reason this fails is that the build script in the recipe.yaml in the tests is written for bash.

build:
number: 0
script: | # (2)!
cmake $CMAKE_ARGS \
-GNinja \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_INSTALL_PREFIX=$PREFIX \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DBUILD_SHARED_LIBS=ON \
-B $SRC_DIR/../build \
-S .

@@ -40,5 +41,5 @@ requirements:
- ninja

host: # (4)!
- python 3.12.*
- python 3.13.*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time we checked that made problems with nanobind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha we changed it now to fix the nanobind issue😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ruben-arts
Copy link
Contributor

The advanced_cpp is fixed on windows, but we can't figure out yet how to test them in CI because of the long paths.

The cpp example should be fixed with: prefix-dev/pixi-build-backends#210

The getting_started should be rewritten as it doesn't work nicely with the recipe ymls and normal python backend side by side. It's currently throwing either clobber errors on rebuild and other issues. I had to stop testing as it was exploding in time.

Might be able to continue later.

@Hofer-Julian
Copy link
Contributor Author

The getting_started should be rewritten as it doesn't work nicely with the recipe ymls and normal python backend side by side. It's currently throwing either clobber errors on rebuild and other issues. I had to stop testing as it was exploding in time.

That's a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:extra_slow Run the extra slow tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants