-
Notifications
You must be signed in to change notification settings - Fork 314
feat: add pixi extensions
command
#4029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Let's make sure that we add docs and tests before we merge it |
To be honest, I don't see the huge benefit of adding this to the CLI. The hard-coded ness of this makes it even less feature rich, as I also see this as something companies will do for their own private tooling. |
You might misunderstand what this CLI does 🙂
We were pondering alternative ideas to have nice descriptions. Considering there are only a limited number of pixi extensions, we felt it was fine to hardcode descriptions in the Pixi code. I'd be happy to hear ideas how this could be made more flexible without adding a lot of complexity. |
pixi extensions
commandpixi extensions
command
Ah, I did indeed misunderstand. It seems like there is not really a standard for this logic yet. Seeing that If we go for |
our preferred solution would have been adding this to |
Yeah that's correct, clap-rs/clap#3166 this issue still has me on the edge of my seat. As that would enable so much more. But If there's ever the idea of adding the Would value @nichmor and @mrswastik-robot's input for this, as they are working on the full implementation. |
tbh, I'm against hardcoding any known extensions' description in pixi itself and would rely on just discovering them from the path. It would then raise the discrepancy questions of - why extension Regarding the |
Do you think we'd need to gate keep this? I would have just accepted every single submission.
I still think that a subcommand makes more sense than a flag like |
What would this command do @ruben-arts? |
I feel that it is |
I don't think we need to gate-keep this, but I think it would still go through a review. And if the extension is |
Honestly, would be fine by me. But I am not at all fixated on hard-coding anything. What I would like though is that we have some CLI, which gives descriptions for extensions. Where Pixi gets them isn't all too important too me as long as it's not too much work for us or the extension developers. Side-note: cargo hardcodes descriptions too. They seem to limit it to certain extensions, though. |
Stole that from |
Yeah, agreed :) |
What about augmenting the |
Sounds good to me! |
closes #3958