feat: add interpreter detection for various script types #1618
+355
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
May 4, 2025
wolfv
reviewed
May 4, 2025
wolfv
reviewed
May 4, 2025
wolfv
reviewed
May 5, 2025
| @@ -40,6 +40,7 @@ requests = ">=2.32.2,<2.33" | |||
| syrupy = "4.6.*" | |||
| rust-src = ">=1.86.0,<1.87" | |||
| boto3 = "*" | |||
| nushell = "==0.104.0" | |||
There was a problem hiding this comment.
I think this can be reverted since you are also requesting nushell in the build requirements of the recipe.
There was a problem hiding this comment.
Nope, github runners for some reason doesnt see it without adding specially to lock file. This could be a bug btw
wolfv
approved these changes
May 5, 2025
# Conflicts: # test/end-to-end/test_simple.py
wolfv
reviewed
May 5, 2025
| tests: | ||
| - script: build.nu | ||
| requirements: | ||
| run: |
There was a problem hiding this comment.
Wrt to removing nushell from pixi, would it work if you use build here, instead of run?
|
Don't merge pls, i will fix the git test section, i messed up the conflict solving with jetbrains merge tool |
|
fixed! @wolfv |
wolfv
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1611
i was debating whetever i should add a UTF-8 validation but i thought it should be added just in case for windows computers with asian languages, let me know what you think about it @wolfv
Also, as shown in recipe examples we still hold the requirements/run to not to cause a magicial workflow, because i thought people want to control exactly what they want to run with