Address next round of review comments

Author: nickclark2016

src/base/oven.lua

@@ -899,62 +899,6 @@
 			return cfg._cfgset.blocks
 		end
 
-		local function buildAppliedPropertyTable(prj, cfg)
-			local blocks = fetchConfigSetBlocks(cfg)
-
-			local properties = {}
-
-			local srcprj = cfg.project
-
-			for _, blk in ipairs(blocks) do
-				if blk._isusage then
-					for key, value in pairs(blk) do
-						local field = p.field.get(key)
-						if field then
-							if field.paths then
-								-- Translate the paths to be relative to the project's location
-								-- Get the absolute path of the field values
-								local absPaths = {}
-								if type(value) == 'table' then
-									for i, v in ipairs(value) do
-										absPaths[i] = path.getabsolute(path.join(srcprj.location, v))
-									end
-								else
-									absPaths = path.getabsolute(path.join(srcprj.location, value))
-								end
-
-								-- Translate the absolute paths to be relative to the target project's location
-								local relPaths = {}
-								if type(absPaths) == 'table' then
-									for i, v in ipairs(absPaths) do
-										relPaths[i] = path.getrelative(prj.location, v)
-									end
-								else
-									relPaths = path.getrelative(prj.location, absPaths)
-								end
-
-								if type(relPaths) == 'table' then
-									verbosef('Translated paths - %s = %s', key, table.concat(relPaths, ","))
-								else
-									verbosef('Translated paths - %s = %s', key, relPaths)
-								end
-							else
-								properties[key] = p.field.store(field, properties[key], value)
-							end
-						end
-					end
-				end
-			end
-
-			for key, value in pairs(properties) do
-				if type(value) == 'table' then
-					verbosef('%s = %s', key, table.concat(value, ","))
-				else
-					verbosef('%s = %s', key, value)
-				end
-			end
-		end
-
 		local function fetchPropertiesToApply(src, tgt)
 			local properties = {}
 			local srcprj = src.project

src/base/project.lua

@@ -573,10 +573,8 @@
 
 
 	function project.findusage(self, name)
-		name = name:lower()
-
 		for _, usage in ipairs(self.usages or self.project.usages) do
-			if name == usage.name:lower() then
+			if name == usage.name then
 				return usage
 			end
 		end

tests/oven/test_usages.lua

@@ -84,7 +84,7 @@
 
         -- Order is important here, as the test treats different order as a failure
         -- However, the order of the defines is not important in the actual implementation
-        test.isequal({ "PROJECT_3", "PROJECT_1_PUBLIC", "PROJECT_1_INTERFACE", "PROJECT_2_PUBLIC", "PROJECT_2_INTERFACE" }, cfg.defines) -- Interface defines should not be included
+        test.isequal({ "PROJECT_3", "PROJECT_1_PUBLIC", "PROJECT_1_INTERFACE", "PROJECT_2_PUBLIC", "PROJECT_2_INTERFACE" }, cfg.defines)
     end
 
 ---
@@ -102,7 +102,7 @@
 
         -- Order is important here, as the test treats different order as a failure
         -- However, the order of the defines is not important in the actual implementation
-        test.isequal({ "MY_CUSTOM_USAGE" }, cfg.defines) -- Interface defines should not be included
+        test.isequal({ "MY_CUSTOM_USAGE" }, cfg.defines)
     end
 
 

website/docs/uses.md

@@ -4,19 +4,20 @@ Specifies which usage blocks a project should consume.
 uses { "ProjectA" }
 ```
 
-The `uses` API is used to consume `usage` blocks from within a project.
+The `uses` API is used to consume `usage` blocks from within a project. The `usage` blocks are case sensitive.
 
 ### Usage resolve priority ###
 
 1. `PUBLIC` and `INTERFACE` usage scopes within a project of the corresponding name.
 2. `usage` blocks with the corresponding name in any scopes.
 
-Note: If there are duplicate usage blocks with the same resolved name, the selected usage block is unspecified. `usage` blocks should have unique names if they are not specified as `PUBLIC`, `PRIVATE`, or `INTERFACE`.
+Note: If there are duplicate usage blocks with the same resolved name, the selected usage block is unspecified. `usage` blocks should have unique names if they are not specified as `PUBLIC`, `PRIVATE`, or `INTERFACE`. If `links` or `linkoptions` are defined within a usage block, it is recommended that `linkgroups` is also turned on.
 
 ### Applies To ###
 
 Projects and usage configurations.
 
 ### See Also ###
 
+* [linkgroups](linkgroups.md)
 * [usage](usage.md)