Fixed visibility flag output for VS Android projects (#2542)

- Added test for flag output

Author: samsinsane

modules/vstudio/tests/_tests.lua

@@ -114,6 +114,7 @@ return {
 	"vc2022/test_toolset_settings.lua",
 
 	-- Android projects
+	"android/test_android_build_settings.lua",
 	"android/test_android_files.lua",
 	"android/test_android_project.lua",
 

modules/vstudio/tests/android/test_android_build_settings.lua

@@ -0,0 +1,36 @@
+local p = premake
+local suite = test.declare("vstudio_vs2010_android_compile_settings")
+local vc2010 = p.vstudio.vc2010
+local project = p.project
+
+--
+-- Setup
+--
+
+	local wks, prj
+
+	function suite.setup()
+		p.action.set("vs2015")
+		system "android"
+		wks, prj = test.createWorkspace()
+	end
+
+	local function prepare(platform)
+		local cfg = test.getconfig(prj, "Debug", platform)
+		vc2010.clCompile(cfg)
+	end
+
+--
+-- Visibility settings should go into AdditionalOptions
+--
+
+	function suite.additionalOptions_onVisibility()
+		visibility "Default"
+		prepare()
+		test.capture [[
+<ClCompile>
+	<PrecompiledHeader>NotUsing</PrecompiledHeader>
+	<Optimization>Disabled</Optimization>
+	<AdditionalOptions>-fvisibility=default %(AdditionalOptions)</AdditionalOptions>
+		]]
+	end

modules/vstudio/vs2010_vcxproj.lua

@@ -4474,7 +4474,7 @@
 
 		-- -fvisibility=<>
 		if cfg.visibility ~= nil then
-			table.insert(opts, p.tools.gcc.cxxflags.visibility[cfg.visibility])
+			table.insert(opts, p.tools.gcc.shared.visibility[cfg.visibility])
 		end
 
 		if #opts > 0 then