-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filters break with spurious whitespace #2420
Comments
If this isn't fixed, it should at least be documented. |
Let me get some tests written to reproduce this, then I'll try to take a look. |
To keep you in the loop, what it appears is happening is that it's searching for a configuration named |
Thanks for the update. I would say documentation is the bare minimum here. It's an easy enough problem to work around - once you know what the problem is. Would it be valid/make sense to print an error message if a filter refers to something it can't find? |
I definitely agree that a documentation update for an immediate resolution is needed, and a future internal work task for the team to investigate input sanitization and normalization. As for error messages, I don't think this would be appropriate. It's perfectly legal for it to match nothing, and that could be the expected behavior depending on the build set up. Perhaps a verbose log at the most would be useful here. |
Yeah, I guess it's quite feasible to have filterable values only available on some platforms, etc. I do that myself, thinking about it. Is it true to say |
As it currently stands, yes |
What seems to be the problem?
Filters break when the filter string contains additional whitespace.
For example, the following works:
while the following does not:
(Note the spaces after the colon.)
What did you expect to happen?
I expected whitespace to be ignored where possible.
What have you tried so far?
I removed the whitespace.
What version of Premake are you using?
5.0.0-beta2
The text was updated successfully, but these errors were encountered: