Rename blockset files to match pokecrystal

[Rangi42]

We're discussing whether to consistently use "metatiles" or "blocks" in pokecrystal: pret/pokecrystal#1171 So far there's a strong opinion in favor of "blocks".

Purpose	pokered	pokecrystal	Notes
Graphics	gfx/tilesets/foo.png	gfx/tilesets/foo.png
Palettes		gfx/tilesets/foo_palette_map.asm
Blocks	gfx/blocksets/foo.bst	data/tilesets/foo_metatiles.bin	pokered's data/tilesets/ has other files
Collision		data/tilesets/foo_collision.asm
Attributes		data/tilesets/foo_attributes.bin	WIki tutorial

Given that the blocks are really just tilemaps (you can view them in Tilemap Studio), I like how pokered stores them in gfx. I'm less sure about having separate directories for tilesets and blocksets, since they correspond so closely.

How does this sound:

1. pokecrystal moves the data/tilesets/* files into gfx/tilesets. Likewise pokered moves the gfx/blocksets/* files into gfx/tilesets.
2. pokecrystal renames foo_metatiles.bin to foo_blocks.bin. Likewise pokered renames foo.bst to foo_blocks.bin.

@dannye Since this is now about syncing pokecrystal with pokered, I'd appreciate your input.

[dannye]

I'm in favor of all the suggested changes. I definitely prefer "blocks" over "metatiles".

I don't feel as strongly about combining blocksets/ into tilesets/ or changing .bst to .bin, but I don't have an argument against it either; as long as "_blocks" is added (as you suggest) so that blockset files still indicate somehow that they are blocksets.

[dannye]

One reason I would consider keeping the .bst file extension; We also have .blk for map blocks. Arguing that blockset files are "just binary data" and therefore .bst should be changed to .bin is just a slippery slope away from saying that .blk should be changed to .bin because it's just binary data. You did say that would be "too disruptive", but then I wonder; what is being gained by renaming .bst?

[Rangi42]

Re: combining blocksets/ into tilesets/, my goal is to be consistent with pokecrystal. pokecrystal currently puts blocksets in data/tilesets/, but pokered shouldn't do that because data/tilesets/ is for various other data files not associated with individual sets.

Alternatively, pokecrystal could make a gfx/blocksets/ or a data/blocksets/ directory, but if we're moving files anyway, it made sense to me to use the existing gfx/tilesets/ directory.

[Rangi42]

Re: renaming .bst to .bin, the difference between that and .blk is that .blk has significance: it's a map of block IDs that can/must be opened by Polished Map. On the other hand, .bst files are just maps of tile IDs like any other tilemap, and the extension has no associated specialized program. (Yes there's Tilemap Studio, but it expects .bin or .tilemap as the generic tilemap extensions, and in any case you don't generally edit blocks with it since Polished Map exists.)

Also, I want both gens to be consistent, and pokecrystal renaming foo_metatiles.bin to foo.bst (when it's right next to foo_collision.asm and maybe foo_attributes.bin) feels more surprising than just renaming to foo_blocks.bin.

[dannye]

Sounds good, no complaints from me.

[vulcandth]

For me I'd like consistency across repos ultimately. Even it turns out to be a mix of the proposed changes, as long as both repos are in sync with the nomenclature that's what I'd like to see if at all possible. 😊

[JustRegularLuna]

I agree with making them consistent, it does get confusing going back and forth between the two currently.