Incorrect diff being generated with eslint v9

[Stono]

I won't repeat all the context; it can be found here prettier/eslint-plugin-prettier#697 (comment) - I've been advised to raise this here instead.

[fisker]

The arguments passed to generateDifferences is

"// This file is auto-generated by @hey-api/openapi-ts\n\nimport type { CancelablePromise } from './core/CancelablePromise';\nimport type { BaseHttpRequest } from './core/BaseHttpRequest';\nimport type { HelloControllerHelloResponse } from './types.gen';\n\nexport class HelloService {\n    constructor(public readonly httpRequest: BaseHttpRequest) { }\n    \n    /**\n     * Say hello\n     * @returns string\n     * @throws ApiError\n     */\n    public hello(): CancelablePromise<HelloControllerHelloResponse> {\n        return this.httpRequest.request({\n            method: 'GET',\n            url: '/api/hello'\n        });\n    }\n    \n}"

and

"// This file is auto-generated by @hey-api/openapi-ts\n\nimport type { CancelablePromise } from './core/CancelablePromise'\nimport type { BaseHttpRequest } from './core/BaseHttpRequest'\nimport type { HelloControllerHelloResponse } from './types.gen'\n\nexport class HelloService {\n  constructor(public readonly httpRequest: BaseHttpRequest) {}\n\n  /**\n   * Say hello\n   * @returns string\n   * @throws ApiError\n   */\n  public hello(): CancelablePromise<HelloControllerHelloResponse> {\n    return this.httpRequest.request({\n      method: 'GET',\n      url: '/api/hello'\n    })\n  }\n}\n"

Difference

[
  { offset: 120, operation: 'delete', deleteText: ';' },
  { offset: 183, operation: 'delete', deleteText: ';' },
  { offset: 248, operation: 'delete', deleteText: ';' },
  {
    offset: 279,
    operation: 'replace',
    insertText: '  constructor(public readonly httpRequest: BaseHttpRequest) {',
    deleteText: '    constructor(public readonly httpRequest: BaseHttpRequest) { '
  },
  { offset: 345, operation: 'delete', deleteText: '    ' },
  { offset: 352, operation: 'delete', deleteText: '  ' },
  {
    offset: 358,
    operation: 'replace',
    insertText: '   ',
    deleteText: '     '
  },
  { offset: 375, operation: 'delete', deleteText: '  ' },
  {
    offset: 398,
    operation: 'replace',
    insertText: '   ',
    deleteText: '     '
  },
  { offset: 422, operation: 'delete', deleteText: '  ' },
  { offset: 432, operation: 'delete', deleteText: '  ' },
  { offset: 500, operation: 'delete', deleteText: '    ' },
  { offset: 548, operation: 'delete', deleteText: '      ' },
  {
    offset: 569,
    operation: 'replace',
    insertText: '      ',
    deleteText: '            '
  },
  {
    offset: 599,
    operation: 'replace',
    insertText: '    })',
    deleteText: '        });'
  },
  { offset: 611, operation: 'delete', deleteText: '  ' },
  {
    offset: 617,
    operation: 'replace',
    insertText: '}',
    deleteText: '    '
  },
  { offset: 622, operation: 'delete', deleteText: '}' }
]

[fisker]

Since the diff is actully correct.

Let's close this, and wait to see what should we do in ESLint or eslint-plugin-prettier first.