Skip to content

Commit 3ac19d9

Browse files
authored
Merge pull request #364 from prezly/feature/dev-19743-support-search_term-inside-the-json-query
[DEV-19743] Declare `search` param support to Coverage & Campaigns APIs
2 parents 3a6fa7e + c29f3b7 commit 3ac19d9

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

src/endpoints/Campaigns/Client.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,23 +19,25 @@ export type Client = ReturnType<typeof createClient>;
1919

2020
export function createClient(api: DeferredJobsApiClient) {
2121
async function list(options: SearchOptions): Promise<ListResponse> {
22-
const { query, limit, offset, sortOrder } = options;
22+
const { search, query, limit, offset, sortOrder } = options;
2323
return api.get<ListResponse>(routing.campaignsUrl, {
2424
query: {
2525
limit,
2626
offset,
27+
search,
2728
query: Query.stringify(query),
2829
sort: SortOrder.stringify(sortOrder),
2930
},
3031
});
3132
}
3233

3334
async function search(options: SearchOptions): Promise<ListResponse> {
34-
const { query, limit, offset, sortOrder } = options;
35+
const { search, query, limit, offset, sortOrder } = options;
3536
return api.post<ListResponse>(routing.campaignsUrl, {
3637
payload: {
3738
limit,
3839
offset,
40+
search,
3941
query,
4042
sort: SortOrder.stringify(sortOrder),
4143
},

src/endpoints/Campaigns/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export interface CampaignResponse {
5050
export interface ListOptions {
5151
limit?: number;
5252
offset?: number;
53+
search?: string;
5354
sortOrder?: SortOrder | string;
5455
}
5556

src/endpoints/Coverage/Client.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export type Client = ReturnType<typeof createClient>;
2121

2222
export function createClient(api: DeferredJobsApiClient) {
2323
async function list(options: ListOptions = {}, scope?: Scope): Promise<ListResponse> {
24-
const { includeDeleted, limit, offset, sortOrder } = options;
24+
const { includeDeleted, limit, offset, search, sortOrder } = options;
2525
// TODO: Switch to `scope` API parameter
2626
const url = scope?.story
2727
? routing.storyCoverageUrl.replace(':story_id', String(scope.story))
@@ -31,13 +31,14 @@ export function createClient(api: DeferredJobsApiClient) {
3131
include_deleted: includeDeleted ? 'on' : undefined,
3232
limit,
3333
offset,
34+
search,
3435
sort: SortOrder.stringify(sortOrder),
3536
},
3637
});
3738
}
3839

3940
async function search(options: SearchOptions = {}, scope?: Scope): Promise<ListResponse> {
40-
const { includeDeleted, query, limit, offset, sortOrder } = options;
41+
const { includeDeleted, search, query, limit, offset, sortOrder } = options;
4142
// TODO: Switch to `scope` API parameter
4243
const url = scope?.story
4344
? routing.storyCoverageUrl.replace(':story_id', String(scope.story))
@@ -46,6 +47,7 @@ export function createClient(api: DeferredJobsApiClient) {
4647
return api.get<ListResponse>(url, {
4748
query: {
4849
include_deleted: includeDeleted ? 'on' : undefined,
50+
search,
4951
query: Query.stringify(query),
5052
limit,
5153
offset,

src/endpoints/Coverage/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export interface ListOptions {
7777
includeDeleted?: boolean;
7878
limit?: number;
7979
offset?: number;
80+
search?: string;
8081
sortOrder?: SortOrder | string;
8182
}
8283

0 commit comments

Comments
 (0)